Skip to content

Clean up documentation in the create_phantom_invoice functions #1997

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

Kurtsley
Copy link
Contributor

Removed the statement that belongs in the changelog.
Added the correct syntax to duration_since_epoch.

@codecov-commenter
Copy link

Codecov Report

Base: 90.85% // Head: 90.88% // Increases project coverage by +0.02% 🎉

Coverage data is based on head (342741a) compared to base (8ecd7c3).
Patch has no changes to coverable lines.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1997      +/-   ##
==========================================
+ Coverage   90.85%   90.88%   +0.02%     
==========================================
  Files          99       99              
  Lines       52570    52570              
  Branches    52570    52570              
==========================================
+ Hits        47763    47776      +13     
+ Misses       4807     4794      -13     
Impacted Files Coverage Δ
lightning-invoice/src/utils.rs 97.62% <ø> (ø)
lightning/src/ln/monitor_tests.rs 99.45% <0.00%> (-0.11%) ⬇️
lightning/src/ln/channelmanager.rs 87.25% <0.00%> (-0.03%) ⬇️
lightning/src/ln/functional_tests.rs 96.87% <0.00%> (+0.24%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@TheBlueMatt TheBlueMatt merged commit c59150a into lightningdevkit:main Jan 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants