Add WriteableScore bindings impl for MultiThreadedLockableScore
#1788
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In 56b07e5 we made `MultiThreadedLockableScore` fully bindings-compatible. However, it did not add a `WriteableScore` implementation for it. This was an oversight as it is a `WriteableScore` in Rust and needs to be for use in other parts of the API. Here we add the required impl in a way that the bindings generator is able to handle it and add conversion utilities.
Codecov ReportBase: 90.71% // Head: 90.73% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #1788 +/- ##
==========================================
+ Coverage 90.71% 90.73% +0.01%
==========================================
Files 87 87
Lines 47316 47316
Branches 47316 47316
==========================================
+ Hits 42924 42931 +7
+ Misses 4392 4385 -7
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
valentinewallace
approved these changes
Oct 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In 56b07e5 we made
MultiThreadedLockableScorefully bindings-compatible. However, it did not add aWriteableScoreimplementation for it. This was an oversight as it is aWriteableScorein Rust and needs to be for use in other parts of the API.Here we add the required impl in a way that the bindings generator is able to handle it and add conversion utilities.