Bump workspace to rust edition 2018

[wpaulino]

Mostly motivated by the need of async/await.

To reproduce, follow https://doc.rust-lang.org/cargo/commands/cargo-fix.html#edition-migration.

[codecov-commenter]

Codecov Report

Base: 90.71% // Head: 90.71% // No change to project coverage 👍

Coverage data is based on head (dbbbd46) compared to base (ad82c9e).
Patch coverage: 90.54% of modified lines in pull request are covered.

❗ Current head dbbbd46 differs from pull request most recent head f4f1093. Consider uploading reports for the commit f4f1093 to get more accurate results

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #1780   +/-   ##
=======================================
  Coverage   90.71%   90.71%           
=======================================
  Files          87       87           
  Lines       47353    47353           
  Branches    47353    47353           
=======================================
  Hits        42958    42958           
  Misses       4395     4395           

Impacted Files	Coverage Δ
lightning-invoice/src/payment.rs	89.85% <ø> (ø)
lightning-invoice/src/ser.rs	92.19% <ø> (ø)
lightning/src/chain/chainmonitor.rs	97.78% <ø> (ø)
lightning/src/chain/channelmonitor.rs	90.70% <ø> (ø)
lightning/src/chain/keysinterface.rs	91.61% <ø> (ø)
lightning/src/chain/mod.rs	68.18% <ø> (ø)
lightning/src/chain/onchaintx.rs	94.17% <ø> (-0.23%)	⬇️
lightning/src/chain/package.rs	92.84% <ø> (ø)
lightning/src/chain/transaction.rs	100.00% <ø> (ø)
lightning/src/debug_sync.rs	95.58% <ø> (ø)
... and 57 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

[dunxen]

Nice. Could you maybe list the combination of commands and args you used? Seems I keep missing some areas. Struggling to reproduce.

[wpaulino]

Could you maybe list the combination of commands and args you used? Seems I keep missing some areas. Struggling to reproduce.

It was quite troublesome, I had to apply the migration multiple times due to numerous imports gated behind different features and config flags. I then committed the changes after each iteration and squashed them all into a single commit.

[dunxen]

It was quite troublesome, I had to apply the migration multiple times due to numerous imports gated behind different features and config flags. I then committed the changes after each iteration and squashed them all into a single commit.

Yeah I think that's pretty much the trouble I'm dealing with. Not getting all the combos of config and features. I'll attempt again in the morning. Think I just had fuzzing left then maybe I can share a repro.

[wpaulino]

In any case, with the edition = 2018 option now in the manifest, the compiler will abort with any remaining errors so we can be sure we've migrated the entirety of the project. As for the changes themselves, while the diff is large, they all involve adding a crate:: prefix to import paths for modules within the same workspace.

[tnull]

Seems this needs a rebase now?

[dunxen]

Alright, I've reproduced this but pretty much also lost track of all the steps. Phew!

[TheBlueMatt]

Can you take the first commit from #1770 so that this doesn't conflict there?

[tnull]

Looks good, now my finger hurts from scrolling.

[wpaulino]

Rebased to address conflicts.

[dunxen]

Oof. All those conflicts 😢

Basically looks good to me unless we still wanted something split out of here into a follow up, or are we happy with the whole package?

[dunxen]

Not sure if we wanted to split any of these changes out as discussed on discord, but this LGTM. Bring on the merge conflicts?

[TheBlueMatt]

Only one note.

[jkczyz]

Everything looks crate!

[jkczyz]

Everything looks crate!

Except the CI error... looks transient.

[TheBlueMatt]

Yea, will give CI a nudge once the others pass, is a networking issue for github CI failing to talk to....github 🤦