-
Notifications
You must be signed in to change notification settings - Fork 411
Fix per-path minimal value contribution during route finding #1526
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix per-path minimal value contribution during route finding #1526
Conversation
SGTM, could use a test, though, IMO. |
5baea6e
to
be095a2
Compare
Since fixating the maximum number of MPP payment paths at 10 seemed at the same time rather arbitrary but also a sane default, I now opted to make The |
a8865ca
to
57cf608
Compare
Squashed commits. |
Codecov Report
@@ Coverage Diff @@
## main #1526 +/- ##
==========================================
+ Coverage 90.95% 90.97% +0.02%
==========================================
Files 80 80
Lines 43431 43661 +230
Branches 43431 43661 +230
==========================================
+ Hits 39503 39722 +219
- Misses 3928 3939 +11
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Feel free to squash.
3380687
to
1dfabcb
Compare
Squashed. |
Fixes #1520
This PR ensures that we don't return an MPP route with more paths than
ChannelManager
would actually send payments over.