-
Notifications
You must be signed in to change notification settings - Fork 411
Bump dependencies to bitcoin 0.27 and bech32 0.8 #1012
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump dependencies to bitcoin 0.27 and bech32 0.8 #1012
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1012 +/- ##
==========================================
+ Coverage 90.82% 90.86% +0.04%
==========================================
Files 60 60
Lines 31455 31584 +129
==========================================
+ Hits 28568 28698 +130
+ Misses 2887 2886 -1
Continue to review full report at Codecov.
|
Cargo.toml
Outdated
@@ -27,3 +27,6 @@ panic = "abort" | |||
opt-level = 3 | |||
codegen-units = 1 | |||
lto = true | |||
|
|||
[patch.crates-io] | |||
core2 = { git = "https://github.com/TheBlueMatt/core2", branch = "main" } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this still [DO NOT MERGE]
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yea, depends on technocreatives/core2#7. I guess we could just bump the CI MSRV version for no-std, but I don't see a reason to - gotta replace the std::io
uses we have with core2
anyway before we can ship no-std, so its not like we're in a rush.
...but disable it for now given core2 is broken (it claims an MSRV of 1.47 but does not build).
e4a1ad8
to
0671ca6
Compare
Dropped the |
ACK |
Interesting test failure though |
The test failure is unrelated. rustc is (probably) going to make an incompatible libstd change soon, so we're failing on beta. I've argued a bit with them, but there's not really a great other way to accomplish what they want (more |
This hasn't materially changed since @jkczyz's last review, just merging. |
Plus various small no_std bits, working towards no_std.