Include htlc_maximum/minimum in ChannelDetails

[TheBlueMatt]

This is useful in the router and we should also pass it as described at #1199 (comment)

[bennyhodl]

Should getting the minimum htlc value be get_holder_htlc_minimum_msat or get_counterparty_htlc_minimum_msat?

For routing it should be the counterparty's minimum htlc value correct?

[TheBlueMatt]

Good question, I assume both, though, yes, for invoice hints we specifically care about our counterparty's parameters as that is what the counterparty applies on htlcs towards us. Presumably in the CounteraprtyForwardingInfo struct.

[bennyhodl]

So in ChannelDetails we would want both holder & counterparty min/max?

API doesn't implement max htlc for counterparty and holder for Channel struct. It just implements the max by taking the minimum of self.channel_value_satoshis * 1000 * 9 / 10 and holder_max_htlc_value_in_flight_msat in get_announced_htlc_max_msat

[TheBlueMatt]

Oops, sorry I took a while to get back to you here, I'll continue discussion on the PR, thanks!

[ViktorTigerstrom]

I could pick this up and continue working on it. Unless you would like to pick it up again @BennyBlockchain?

[TheBlueMatt]

Sounds great.