Skip to content

Post-1054 follow-ups #1175

Open
Open
@ariard

Description

@ariard

We have likely few redundant checks in send_htlc (see #1054 (comment)), cleaning them would ease the refactoring of our fee(s) accounting helpers (next_local_commit_tx_msat, get_inbound_htlcs, build_commitment, etc) as consumed by the affordance checks at HTLC sending and reception. There is at least fixing the check in update_add_htlc by using the correct anticipated value instead of value_to_self_msat (see #1054 (comment)). And likely adding test coverage, especially w.rt handling of dust/dust_limit_satoshis.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions