Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: lightningdevkit/rust-lightning
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: e4e9fd7
Choose a base ref
...
head repository: lightningdevkit/rust-lightning
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 7bf0469
Choose a head ref
  • 11 commits
  • 8 files changed
  • 1 contributor

Commits on Oct 18, 2023

  1. f - update TooFewBlindedHops docs

    @jkczyz
    jkczyz committed Oct 18, 2023
    Configuration menu
    Copy the full SHA
    ef3ec51 View commit details
    Browse the repository at this point in the history

  2. f - remove unneeded code

    @jkczyz
    jkczyz committed Oct 18, 2023
    Configuration menu
    Copy the full SHA
    ccf6d7e View commit details
    Browse the repository at this point in the history

  3. Remove outdated docs

    @jkczyz
    jkczyz committed Oct 18, 2023
    Configuration menu
    Copy the full SHA
    1c5a7b3 View commit details
    Browse the repository at this point in the history

  4. Await invoice for variable number of timer ticks 

    PendingOutboundPayment::AwaitingInvoice counts the number of timer ticks
that have passed awaiting a Bolt12Invoice for an InvoiceRequest. When a
constant INVOICE_REQUEST_TIMEOUT_TICKS has passed, the payment is
forgotten. However, this mechanism is insufficient for the Refund
scenario, where the Refund's expiration should be used instead.

Change AwaitingInvoice to store the number of timer ticks remaining
instead of the number that has passed. This allows for a variable number
of ticks that are instead counted down.
    @jkczyz
    jkczyz committed Oct 18, 2023
    Configuration menu
    Copy the full SHA
    7e98017 View commit details
    Browse the repository at this point in the history

  5. f - use system/block time instead of ticks for removing stale Awaitin… 

    …gInvoice
    @jkczyz
    jkczyz committed Oct 18, 2023
    Configuration menu
    Copy the full SHA
    e7df074 View commit details
    Browse the repository at this point in the history

  6. f - update timer_tick_occurred docs

    @jkczyz
    jkczyz committed Oct 18, 2023
    Configuration menu
    Copy the full SHA
    48f24b2 View commit details
    Browse the repository at this point in the history

  7. Stateless offer and refund builder utilities 

    Add utility functions to ChannelManager for creating OfferBuilder,
and RefundBuilder such that derived keys are used for the signing
pubkey and payer id, respectively. This allows for stateless
verification of any InvoiceRequest and Invoice messages.

Later, blinded paths can be included in the returned builders.

Also tracks future payments using the given PaymentId such that the
corresponding Invoice is paid only once.
    @jkczyz
    jkczyz committed Oct 18, 2023
    Configuration menu
    Copy the full SHA
    86252ea View commit details
    Browse the repository at this point in the history

  8. f - pass absolute expiry to create_refund_builder

    @jkczyz
    jkczyz committed Oct 18, 2023
    Configuration menu
    Copy the full SHA
    2ea457e View commit details
    Browse the repository at this point in the history

  9. f - use absolute expiry in add_new_awaiting_invoice

    @jkczyz
    jkczyz committed Oct 18, 2023
    Configuration menu
    Copy the full SHA
    d2848f3 View commit details
    Browse the repository at this point in the history

  10. f - fix create_refund_builder docs

    @jkczyz
    jkczyz committed Oct 18, 2023
    Configuration menu
    Copy the full SHA
    1059231 View commit details
    Browse the repository at this point in the history

  11. Include a one-hop blinded path in Offer and Refund 

    While this doesn't add much privacy over not including any blinded
paths, it allows us to exercise code for receiving on blinded paths.
    @jkczyz
    jkczyz committed Oct 18, 2023
    Configuration menu
    Copy the full SHA
    7bf0469 View commit details
    Browse the repository at this point in the history
Loading