Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: lightningdevkit/rust-lightning
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: d5bd25c
Choose a base ref
...
head repository: lightningdevkit/rust-lightning
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: dc2b11f
Choose a head ref
  • 11 commits
  • 8 files changed
  • 3 contributors

Commits on Mar 20, 2023

  1. Drop serde dependency from lightning-block-sync 

    `serde` doesn't bother with MSRVs, so its expected to break
frequently. Yesterday, the `derive` feature had its MSRV broken in
a patch version without care.

Luckily its trivial for us to remove the `serde` dependency in
`lightning-block-sync`, using only `serde_json` for the JSON
deserialization part. It even ends up net-negative on LoC.
    @TheBlueMatt
    TheBlueMatt committed Mar 20, 2023
    Configuration menu
    Copy the full SHA
    b701a6c View commit details
    Browse the repository at this point in the history

  2. Merge pull request #2116 from TheBlueMatt/2023-03-serde-sucks 

    Drop `serde` dependency from `lightning-block-sync`
    @TheBlueMatt
    TheBlueMatt authored Mar 20, 2023
    Configuration menu
    Copy the full SHA
    86e94c4 View commit details
    Browse the repository at this point in the history

  3. Implement PartialEq manually 

    Since we don't store `pending_claim_events` within `OnchainTxHandler` as
they'll be regenerated on restarts, we opt to implement `PartialEq`
manually such that the field is not longer considered.
    @wpaulino
    wpaulino committed Mar 20, 2023
    Configuration menu
    Copy the full SHA
    cfa8941 View commit details
    Browse the repository at this point in the history

  4. Derive Eq on structs behind anchors build flag

    @wpaulino
    wpaulino committed Mar 20, 2023
    Configuration menu
    Copy the full SHA
    e7fb47b View commit details
    Browse the repository at this point in the history

  5. Fix stale import behind anchors build tag

    @wpaulino
    wpaulino committed Mar 20, 2023
    Configuration menu
    Copy the full SHA
    1958626 View commit details
    Browse the repository at this point in the history

  6. Add missing docs for BumpHTLCResolution

    @wpaulino
    wpaulino committed Mar 20, 2023
    Configuration menu
    Copy the full SHA
    7c446b4 View commit details
    Browse the repository at this point in the history

  7. Clarify OnchainEvent::Claim behavior 

    The previous documentation was slightly incorrect, a `Claim` can also be
from the counterparty if they happened to claim the same exact set of
outputs as a claiming transaction we generated.
    @wpaulino
    wpaulino committed Mar 20, 2023
    Configuration menu
    Copy the full SHA
    1638c8b View commit details
    Browse the repository at this point in the history

  8. Rename keys for OnchainTxHandler::claimable_outpoints map

    @wpaulino
    wpaulino committed Mar 20, 2023
    Configuration menu
    Copy the full SHA
    7b9c28a View commit details
    Browse the repository at this point in the history

  9. Maintain order of yielded claim events 

    Since the claim events are stored internally within a HashMap, they will
be yielded in a random order once dispatched. Claim events may be
invalidated if a conflicting claim has confirmed on-chain and we need to
generate a new claim event; the randomized order could result in the
new claim event being handled prior to the previous. To maintain the
order in which the claim events are generated, we track them in a Vec
instead and ensure only one instance of a PackageId only ever exists
within it.

This would have certain performance implications, but since we're
bounded by the total number of HTLCs in a commitment anyway, we're
comfortable with taking the cost.
    @wpaulino
    wpaulino committed Mar 20, 2023
    Configuration menu
    Copy the full SHA
    4be56b9 View commit details
    Browse the repository at this point in the history

  10. Add test for aggregated revoked HTLC claim on anchors channel

    @wpaulino
    wpaulino committed Mar 20, 2023
    Configuration menu
    Copy the full SHA
    2cc48c5 View commit details
    Browse the repository at this point in the history

  11. Test anchors build in CI

    @wpaulino
    wpaulino committed Mar 20, 2023
    Configuration menu
    Copy the full SHA
    dc2b11f View commit details
    Browse the repository at this point in the history
Loading