Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: lightningdevkit/rust-lightning
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 886b7e3
Choose a base ref
...
head repository: lightningdevkit/rust-lightning
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 8db91d7
Choose a head ref
  • 2 commits
  • 10 files changed
  • 1 contributor

Commits on Jan 27, 2024

  1. Support normal channel operation with async signing 

    This is a do-over of #2653, wherein we support asynchronous signing for
'normal' channel operation. This involves allowing the following
`ChannelSigner` methods to return an `Err` result, indicating that the
requested value is not available:

- get_per_commitment_point
- release_commitment_secret
- sign_counterparty_commitment

When the value does become available, channel operation can be resumed by
invoking `signer_unblocked`.

Note that this adds the current and next per-commitment point to the state
that is persisted by the channel monitor.
    @waterson
    waterson committed Jan 27, 2024
    Configuration menu
    Copy the full SHA
    1bea55f View commit details
    Browse the repository at this point in the history

  2. Allow async sigs during channel setup 

    Creates and manages an explicit `HolderCommitment` type to deal with managing
the current and next commitment points.
    @waterson
    waterson committed Jan 27, 2024
    Configuration menu
    Copy the full SHA
    8db91d7 View commit details
    Browse the repository at this point in the history
Loading