Adds missing commands to CLI #34
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
G8XSU
reviewed
Dec 9, 2024
Contributor
G8XSU
left a comment
G8XSU
left a comment
There was a problem hiding this comment.
Some doc changes to make them consistent with our proto definitions.
Otherwise Lgtm, please squash after fixes.
|
|
||
| #[derive(Subcommand, Debug)] | ||
| enum Commands { | ||
| GetNodeInfo, |
Contributor
There was a problem hiding this comment.
nits:
- Can you change commit msgs to something like "Add Cli command for OnchainSend"
- And remove the commit description 'signed-off by ...'
- and include formatting changes in their corresponding commits, instead of separate commit.
dzdidi
force-pushed
the
main
branch
6 times, most recently
from
b46e889 to
a825f12
Compare
Fix typo in readme Add cli command for GetNodeInfo Add cli command for GetBalance Add cli command for ListChannels Add cli command for ListPayments Co-authored-by: Gursharan Singh <3442979+G8XSU@users.noreply.github.com>
G8XSU
approved these changes
Dec 9, 2024
Contributor
G8XSU
left a comment
G8XSU
left a comment
There was a problem hiding this comment.
Looks like you squashed all commits into one, not sure if it was intended.
But this is ok.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added missing cli commands for:
get-node-infoget-balanceslist-channelslist-paymentsNot exactly sure what the signature for
update-channel-configshould be there for have not added it yet but happy to do it