Skip to content

Remove erroneous debug_assert when handling PaymentForwarded #665

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 16, 2025
Merged

Remove erroneous debug_assert when handling PaymentForwarded #665

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 4 additions & 10 deletions src/event.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1289,16 +1289,10 @@ where
}

if let Some(liquidity_source) = self.liquidity_source.as_ref() {
if let Some(skimmed_fee_msat) = skimmed_fee_msat {
liquidity_source
.handle_payment_forwarded(next_channel_id, skimmed_fee_msat)
.await;
} else {
debug_assert!(
false,
"We expect skimmed_fee_msat to be set since LDK 0.0.122"
);
}
let skimmed_fee_msat = skimmed_fee_msat.unwrap_or(0);
Copy link
Contributor

@joostjager joostjager Oct 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And None can happen when we upgrade while there are still unprocessed events on disk?

Copy link
Collaborator Author

@tnull tnull Oct 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, though they'd need to upgrade directly from an LDK Node version prior to 0.3.0, which shipped June 2024. I don't think we have any users that would still run such an old version, let alone as a forwarding node. And the LSP functionality was ofc. also introduced later than this.

liquidity_source
.handle_payment_forwarded(next_channel_id, skimmed_fee_msat)
.await;
}

let event = Event::PaymentForwarded {
Expand Down