Allow disabling wallet background syncing#508
Merged
tnull merged 1 commit intolightningdevkit:mainfrom Mar 28, 2025
Merged
Conversation
alexanderwiederin
force-pushed
the
optional-wallet-sync
branch
from
351c4e6 to
43ba1db
Compare
tnull
reviewed
Mar 26, 2025
Collaborator
tnull
left a comment
tnull
left a comment
There was a problem hiding this comment.
Thanks for looking into this!
alexanderwiederin
force-pushed
the
optional-wallet-sync
branch
5 times, most recently
from
e506206 to
29469ac
Compare
tnull
reviewed
Mar 27, 2025
Collaborator
tnull
left a comment
tnull
left a comment
There was a problem hiding this comment.
Already looks pretty good, some comments.
alexanderwiederin
force-pushed
the
optional-wallet-sync
branch
from
3911d93 to
0772fe7
Compare
tnull
reviewed
Mar 27, 2025
Collaborator
tnull
left a comment
tnull
left a comment
There was a problem hiding this comment.
LGTM, I think, please squash the fixups and undraft the PR.
Please also update the commit message to give some context on what the changes are and why we're applying them. Going forward it would also be nice if you could clearly mark fixup commits (e.g., via a f or fixup prefix in the first line of the message). See https://cbea.ms/git-commit/ for some guidance on how to write good commit messages.
tnull
reviewed
Mar 27, 2025
Implements BackgroundSyncConfig to control background wallet synchronization behavior. - Allows users to explicitly disable background wallet synchronization - Sets intervals to minimum threshold if specified value is below it Context: Some users have setups where they need to rely exclusively on manual syncing. Previously, they had to set intervals to u64::MAX as a workaround to effectively disable background syncing. This implementation provides a cleaner, explicit approach for controlling sync behavior when manual syncing via sync_wallets() is preferred. Breaking change: Existing implementations may need updates to accommodate the new configuration structure. Closes lightningdevkit#310
alexanderwiederin
force-pushed
the
optional-wallet-sync
branch
from
0772fe7 to
bbe8b1e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow disabling background wallet synchronization
Closes #310.
Changes:
Breaking Change:
Existing implementations may need updates to accommodate the new configuration structure.
Implementation Notes:
The BackgroundSyncConfig may be reused for other backend implementations.
Context:
Some users have setups where they need to rely exclusively on manual syncing via
sync_wallets(). Previously, they had to set intervals tou64::MAXas a workaround to effectively disable background syncing. This implementation provides a cleaner, more explicit approach for controlling sync behavior when manual syncing is preferred.