Skip to content

Add initial README and crate-level docs #49

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 22, 2023

Conversation

tnull
Copy link
Collaborator

@tnull tnull commented Mar 21, 2023

No description provided.

@tnull tnull requested a review from jkczyz March 21, 2023 15:55
@tnull tnull force-pushed the 2023-03-add-readme-crate-docs branch 2 times, most recently from 5967ecb to 0df678a Compare March 21, 2023 16:05
@tnull tnull force-pushed the 2023-03-add-readme-crate-docs branch from 0df678a to cafdda2 Compare March 21, 2023 16:06
@moneyball
Copy link

Looks like a good initial write-up to me.

Copy link
Contributor

@jkczyz jkczyz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Largely looks good.

README.md Outdated
A ready-to-go node implementation built using LDK.
A ready-to-go Lightning node library built using [LDK](https://lightningdevkit.org/) and [BDK](https://bitcoindevkit.org/).

LDK Node is a non-custodial Lightning node in library form. Its central goal is to provide a small, simple, and straightforward interface that enables users to easily setup and run a Lightning node with an integrated on-chain wallet. While minimalism is at its core, LDK Node aims to be sufficiently modular and configurable to be useful for a variety of use cases.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@moneyball Any opinion on self-custodial vs non-custodial?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't feel strongly about it. Non-custodial is fine.

@tnull tnull linked an issue Mar 21, 2023 that may be closed by this pull request
Copy link
Contributor

@jkczyz jkczyz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feel free to squash

@tnull tnull merged commit e88b765 into lightningdevkit:main Mar 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add usage example and check docs
3 participants