Pin idna_adapter to fix MSRV CI#480
Merged
arik-so merged 1 commit intolightningdevkit:mainfrom Mar 3, 2025
Merged
Conversation
Starting with v1.2, the `idna_adapter` crate switched to use `icu4x`, which requires a rust version of 1.81, conflicting with our MSRV. Here, we hence pin `idna_adapter` to v1.1 in our MSRV CI.
arik-so
approved these changes
Mar 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Starting with v1.2, the
idna_adaptercrate switched to useicu4x, which requires a rust version of 1.81, conflicting with our MSRV.Here, we hence pin
idna_adapterto v1.1 in our MSRV CI.