Skip to content

per_commitment_secret must be a valid secret key #859

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
TheBlueMatt merged 1 commit into from
Apr 12, 2021
Merged

per_commitment_secret must be a valid secret key #859

TheBlueMatt merged 1 commit into from
Apr 12, 2021

Conversation

@LLFourn
Copy link
Contributor

@LLFourn LLFourn commented Mar 31, 2021

Fixes #832

@t-bast t-bast mentioned this pull request Apr 8, 2021
Closed
9 tasks
@TheBlueMatt TheBlueMatt merged commit a9db80e into lightning:master Apr 12, 2021
@TheBlueMatt
Copy link
Collaborator

TheBlueMatt commented Apr 12, 2021

Meeting discussion:

<niftynei> #topic per_commitment_secret must be a valid secret key
<niftynei> #link https://github.com/lightningnetwork/lightning-rfc/pull/859
<BlueMatt> looks like it has acks
<BlueMatt> can we just merge?
<cdecker> ack
<bitconner> ack
<t-bast> ack
<BlueMatt> merged
<niftynei> ok great, that's resolved.

@LLFourn LLFourn deleted the patch-1 branch April 12, 2021 23:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TheBlueMatt TheBlueMatt TheBlueMatt approved these changes

@t-bast t-bast t-bast approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

BOLT 2: Does not specify how to "generate" point from per_commitment_secret

3 participants

@LLFourn @TheBlueMatt @t-bast