Skip to content

Add bLIP 50: LSP Spec Transport Layer (LSPS0) #52

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 13, 2024

Conversation

tnull
Copy link
Contributor

@tnull tnull commented Dec 2, 2024

The LSPS0 specification defines a protocol that is used for communcations between LSP nodes and their clients. To this end it utilizes a JSON-RPC format spoken over BOLT8 peer-to-peer messages.

The given protocol has been previously stabilized by the LSP Spec group and is live in production with several LSP and client implementations today.

As previously discussed on multiple occasions, the LSP Spec group is however moving to a bLIP-centric process, which is why we 'upstream' these previously-stabilized specifications here.

(cc the original author @ZmnSCPxj-jr)

Copy link
Contributor

@t-bast t-bast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Technically this should be bLIP-52 (matching the PR number ensures we avoid conflicts, as explained in bLIP1. But we don't care much, PR #50 was merged and wasn't adding a bLIP, so you can keep 50.

> might not be directly contactable) was deemed unnecessary for
> most client-LSP communication needs.

All LSPS messages MUST use the [BOLT8][] message ID 37913
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This message ID must be reserved in bLIP 2.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is though? Is there anything else to be done besides adding it to the Messages table?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No that's it, it looks like this is the only message you're using, and you've already registered the feature bit.

@t-bast
Copy link
Contributor

t-bast commented Dec 12, 2024

It would be useful to include a list of known implementations with a link to the code.

@tnull
Copy link
Contributor Author

tnull commented Dec 13, 2024

Technically this should be bLIP-52 (matching the PR number ensures we avoid conflicts, as explained in bLIP1. But we don't care much, PR #50 was merged and wasn't adding a bLIP, so you can keep 50.

Ah, cool, excuse the oversight!,I had overlooked that rule and simply looked for an empty namespace, while aligning the last number with the 'original' LSPS number to make it easier to remember. Thanks!

It would be useful to include a list of known implementations with a link to the code.

Will do! Note that lightning-liquidity as of today resides over at https://github.com/lightningdevkit/lightning-liquidity but we're in the middle of upstreaming it to rust-lightning (eta: ~1-3days), so I added the new location.

@t-bast
Copy link
Contributor

t-bast commented Dec 13, 2024

Note that lightning-liquidity as of today resides over at https://github.com/lightningdevkit/lightning-liquidity but we're in the middle of upstreaming it to rust-lightning (eta: ~1-3days), so I added the new location.

Sounds good, let's merge with the new location right now then.

@tnull
Copy link
Contributor Author

tnull commented Dec 13, 2024

Sounds good, let's merge with the new location right now then.

I'll squash the fixup right now!

The LSPS0 specification defines a protocol that is used for
communcations between LSP nodes and their clients. To this end it
utilizes a JSON-RPC format spoken over BOLT8 peer-to-peer messages.

The given protocol has been previously stabilized by the LSP
Spec group and is live in production with several LSP and client
implementations today.

As previously discussed on multiple occasions, the LSP Spec
group is however moving to a bLIP-centric process, which is why we
'upstream' these previously-stabilized specifications here.
@tnull tnull force-pushed the 2024-12-add-lsps0 branch from 8497273 to 4daf56a Compare December 13, 2024 13:06
@t-bast t-bast merged commit 1eef0e5 into lightning:master Dec 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants