Add iframe/pym links and Fix authentication. #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@minyk thanks! Both of these changes LGTM, and great to fix the auth stuff. If you just fix that one typo I'll merge in. |
- Add response check for error.
|
Typo fixed! Thanks. |
|
Perfect, thanks! Merging in. |
freeman-lab
added a commit
that referenced
this pull request
Apr 8, 2015
Add iframe/pym links and Fix authentication.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add iframe and pym links for Visualization.
Fix for HTTP basic authentication.
val requesttovar requestandrequest.auth()torequest = request.auth()