including line streaming visualization #11
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @Siouffy, this is looking good! It seems like the file |
|
done ;) |
There was a problem hiding this comment.
This should be package org.viz.lightning.types
|
@Siouffy looks good, thanks a lot for this! if you want to fix these two small things i can merge in. |
…moving lineStreaming function to Plots.
|
@mathisonian @freeman-lab ... Done. I included the lineStreaming function in the "Plots" instead of being in a separate class ... This time I did the testing in isolation of my project so I'm sure I'm not forgetting anything :D ... |
|
Excellent, thanks @Siouffy ! Merging in. |
freeman-lab
added a commit
that referenced
this pull request
Aug 16, 2015
including line streaming visualization
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a small addition for the api to include line-streaming visualization. Just added a trait for StreamingVisualization and a appendData method at the visualization class. Note that, in the lineSteaming function, the size parameter is mandatory (not optional). line-streaming doesnt work without the size parameter being specified.