-
Notifications
You must be signed in to change notification settings - Fork 32
Client only mode #26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Client only mode #26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This test is only valid if we’re running in ipython (which we are not, by default, on travis) for now we’ll drop it
Embed script
…tning-python into headless-experimental * 'headless-experimental' of github.com:lightning-viz/lightning-python: Remove stray line Remove host
…tning-python into headless-experimental * 'headless-experimental' of github.com:lightning-viz/lightning-python: Set local to false for streaming
merging after some offline testing w/ @mathisonian |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a client-only or "headless" mode.
This mode makes it possible to generate visualizations without running a server, or even an internet connection. It renders data directly into a template (with
jinja2
) and appends a bundled version of the javascript for all of Lightning's visualizations.With this, we can render most of Lightning's visualizations with just a
pip install
. It does not support all visualizations, and does not support functionality that involves communication between visualization and client (e.g. returning selections). But is provides a particularly simple entry-point, especially for notebooks, and provides faster rendering by avoiding data transfer.It should be reasonably easy to add this functionality to the other clients. And we can push updates to the core visualizations to all the clients just by updating the embedded JS file.