Cast ranges to lists for force and adjacency plots #17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
freeman-lab
changed the title
|
This LGTM, will merge in. Just modified the title to make it a little shorter. Thanks for the contribution @brianbreitsch ! |
freeman-lab
added a commit
that referenced
this pull request
May 2, 2015
Cast ranges to lists for force and adjacency plots
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a fix for the problem addressed in this issue: #16
This will enable Python 3 users to use Lightning without getting errors when plotting.
The errors were due to the difference between the ways Python 2 and Python 3 handle the
rangebuilt-in. Python 2rangereturns an actual container of values, whereas Python 3rangereturns an iterator object. By castingrangetolist, it forces Python 3 to create a container for the values of therangeiterator, while Python 2 will behavior remains the same.