Make JSX types independent of solid-js#34
Open
thetarnav wants to merge 3 commits intolightning-tv:rc3from
Open
Make JSX types independent of solid-js#34thetarnav wants to merge 3 commits intolightning-tv:rc3from
thetarnav wants to merge 3 commits intolightning-tv:rc3from
Conversation
Contributor
|
Can we close this out in favor of #35 going in |
Member
Author
|
I still think there is value here so I don’t think of it as closed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes the
JSXnamespace separate from one insolid-js.Unfortunately even though we implement a custom renderer and don't use
solid-js/web, we cannot use theJSXnamespace fromsolid-jsas it is reexported fromsolid-js/web. (Related issue: solidjs/solid#2051)Because of this, every function that uses
JSXfromsolid-js(likeShow,For, orRoutefrom the solidjs router) need to be implemented as the twoJSXnamespaces are not compatible.So now
@lightningtv/solidreexports everything fromsolid-jswhile "fixing" the types, so now everything can (has to) be imported from@lightningtv/solid.With this
"jsxImportSource"has to also be set to"@lightningtv/solid"to use the newJSXtypes.This is quite a breaking change type-wise.