Remove event listeners of previous route component#89
Open
suresh-gangumalla wants to merge 1 commit intolightning-js:masterfrom
Open
Remove event listeners of previous route component#89suresh-gangumalla wants to merge 1 commit intolightning-js:masterfrom
suresh-gangumalla wants to merge 1 commit intolightning-js:masterfrom
Conversation
Removing event listeners of previous route component before creating target(next) route component instance. Signed-off-by: Suresh Kumar Gangumalla <sureshkumar.gangumalla@invecas.com>
michielvandergeest
requested changes
May 6, 2024
Collaborator
michielvandergeest
left a comment
michielvandergeest
left a comment
There was a problem hiding this comment.
As discussed offline:
I think the responsibility of removing listeners does not lie with the router, but should be in the component. As the component already does this clean up, we should probably find a way to indicate to the component to (temporarily) not handle events, via a method or a property on the component.
This removes the need for having to re-register event listeners for when a previous page has the option to keep the page in memory. Also, since pages can stay in memory we need a flag or method to unset the "ignore events" behaviour.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removing event listeners of previous route component before creating target(next) route component instance.