Format & format-check: only target python directories #1831
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1831 +/- ##
=======================================
Coverage 85.69% 85.69%
=======================================
Files 164 164
Lines 6921 6921
=======================================
Hits 5931 5931
Misses 990 990 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Makes the format & format-check only target python directories. This is relevant for users having other python directories which should not be formatted.
E.g. it prevents problems like this one:
.venv_3p7__minimalmalteebnerlightly@Maltes-MacBook-Pro lightly % make format isort . Fixing /Users/malteebnerlightly/Documents/GitHub/lightly/.venv_3p10/bin/f2py Fixing /Users/malteebnerlightly/Documents/GitHub/lightly/.venv_3p10/bin/numpy-config