Moving positional embedding functions from ijepa to utils #1322
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #1322 +/- ##
==========================================
- Coverage 85.17% 84.76% -0.41%
==========================================
Files 127 127
Lines 5369 5422 +53
==========================================
+ Hits 4573 4596 +23
- Misses 796 826 +30
☔ View full report in Codecov by Sentry. |
guarin
reviewed
Jul 17, 2023
guarin
approved these changes
Jul 17, 2023
There was a problem hiding this comment.
LGTM! Thanks for the PR!
I formatted the files and cleaned up git history. You can run formatting with make format, see our contribution guide: https://github.com/lightly-ai/lightly/blob/master/CONTRIBUTING.md
Regarding git history, could you next time make a PR from a clean branch based on lightly/master? The we don't get all the additional commits in the history. Thanks!
|
@guarin Thank you. Next time I'll do it according to contribution guide. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move positional embedding functions from ijepa to utils