Skip to content

Conversation

guarin
Copy link
Contributor

@guarin guarin commented Apr 25, 2023

Changes

  • Move test_benchmarking.py to benchmarking/test_benchmark_module.py
  • Add benchmarking/test_knn.py
  • Cleanup dimensions in knn_predict docstring/comments.

@codecov
Copy link

codecov bot commented Apr 25, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (950fec3) 88.24% compared to head (da975a6) 88.24%.

Additional details and impacted files
@@                                   Coverage Diff                                   @@
##           guarin-lig-3049-add-simclr-imagenet-resnet50-benchmark    #1165   +/-   ##
=======================================================================================
  Coverage                                                   88.24%   88.24%           
=======================================================================================
  Files                                                         139      139           
  Lines                                                        5774     5774           
=======================================================================================
  Hits                                                         5095     5095           
  Misses                                                        679      679           
Impacted Files Coverage Δ
lightly/utils/benchmarking/knn.py 100.00% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@huan-lightly-0 huan-lightly-0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks okay. What does test_knn actually test?

@guarin
Copy link
Contributor Author

guarin commented Apr 26, 2023

Looks okay. What does test_knn actually test?

It tests if the knn matching works correctly and the correct predicted_classes are returned.

@guarin guarin merged commit d75df4e into guarin-lig-3049-add-simclr-imagenet-resnet50-benchmark Apr 26, 2023
@guarin guarin deleted the guarin-lig-3049-add-benchmarking-tests branch April 26, 2023 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants