-
Notifications
You must be signed in to change notification settings - Fork 284
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Fourier Domain Augmentations #1646
Comments
Hi @guarin , I'd like to work on this issue. Could you please guide me on where to create the necessary files? Knowing this will help streamline my work. |
Hi! Thanks for looking into this! Transforms should be added to Please also add minimal tests to For the fourier transforms I would assume that the inputs are already tensors (the user added a For general info on how to contribute please have a look at: https://github.com/lightly-ai/lightly/blob/master/CONTRIBUTING.md |
Hey @guarin , Is this issue still being worked on by someone else, or could I also look into it? |
Hi! None of the transforms have been implemented so far, so all of them are still up for grabs. @KekmaTime did you already have time to look into this? |
@guarin hey. yes you can assign this to someone else as i've been a bit busy irl 👍🏽 |
Hi @guarin, I'm interested in contributing to this issue for implementing Fourier Domain Augmentations. I have experience with PyTorch and image processing, and I'd like to help implement one or more of the required transforms. Given that there are multiple transforms needed and some contributors may have already started working, I have a few questions:
I've reviewed the CONTRIBUTING.md and am prepared to follow the project's guidelines. I'd be happy to start with whichever transform you think would be most helpful to tackle next. Thank you for considering my contribution! |
Hi, I created issues for the different transforms. Please indicate which transform you would like to work on and I can assign the issue to you :) Will add more info about the issues shortly. |
@belloibrahv I added some more information to the issue description, hopefully this clarifies your questions :) Regarding edge cases I wouldn't worry too much, as long as it works for images with height and width >= 32 pixels it should be good. If there is anything you deem important you can mention it in the PR or leave a comment in the code. I also contacted the authors to get access to the source code, this should help with the implementation. |
Add augmentations from Disentangling the Effects of Data Augmentation and Format Transform in Self-Supervised Learning of Image Representations.
Todo
Please create one PR per transform.
The following hyperparameters should be implemented:
The augmentations are explained in more detail in Section 4 of the paper. All augmentations should take a tensor as input and return a tensor again. Tensors must have shape
(C, H, W)
. See https://github.com/lightly-ai/lightly/blob/master/lightly/transforms/rotation.py for an example implementation of a transform.For unit tests please just assert that the expected shape of the output is correct. We don't require more tests because testing transforms is tricky. Ideally you can also create some example images where the transform was applied (take an image, load it with PIL, convert it to a tensor with
ToTensor
transform from torchvision, apply the newly implemented transform, covert back to image usingToPILImage
and upload the final image). Best vary the hyperparameters a bit to see how they affect the final images.The text was updated successfully, but these errors were encountered: