Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

consolidations, withdrawals: output request type #22

Closed
wants to merge 18 commits into from

Conversation

fjl
Copy link
Contributor

@fjl fjl commented Sep 26, 2024

This changes the contracts to add the request type into the output buffer.

@fjl
Copy link
Contributor Author

fjl commented Sep 26, 2024

Note the type is not added into the log data.

Copy link
Contributor

@mkalinin mkalinin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@fjl
Copy link
Contributor Author

fjl commented Sep 26, 2024

Needs some more updates to the tests. It's going to need a lot of changes to the consolidations tests.

src/consolidations/main.eas Outdated Show resolved Hide resolved
@lightclient lightclient reopened this Sep 27, 2024
src/consolidations/main.eas Outdated Show resolved Hide resolved
@fjl
Copy link
Contributor Author

fjl commented Sep 30, 2024

Closing in favor of #25

@fjl fjl closed this Sep 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants