This repository was archived by the owner on May 25, 2023. It is now read-only.
create labels for endpoint names + probe application.conf for actual port assignments #164
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned
eed3si9n
added a commit
to eed3si9n/reactive-cli
that referenced
this pull request
Jan 8, 2019
Fixes lightbend#177 This specifies the management endpoint name explicity to `-Dakka.management.cluster.bootstrap.contact-point-discovery.port-name`. By default the management endpoint name will fallback to `"akka-mgmt-http"` for backward compatibility. In the future, sbt-reactive-app can declare the management endpoint name using "management-endpoint" as a label on the Docker image. See lightbend/sbt-reactive-app#164. These changes combined together provides softlanding of the switch to `"management"` in akka/akka-management#274.
eed3si9n
added a commit
to eed3si9n/reactive-cli
that referenced
this pull request
Jan 8, 2019
Fixes lightbend#177 This specifies the management endpoint name explicity to `-Dakka.management.cluster.bootstrap.contact-point-discovery.port-name`. By default the management endpoint name will fallback to `"akka-mgmt-http"` for backward compatibility. In the future, sbt-reactive-app can declare the management endpoint name using "management-endpoint" as a label on the Docker image. See lightbend/sbt-reactive-app#164. These changes combined together provides softlanding of the switch to `"management"` in akka/akka-management#274.
|
When running an akka cluster in a service-mesh (like istio), then there is a requirement for port names.
For akka-management the |
|
@thomschke This PR is making the names consistent with Akka Management's doc. If the default value should be changed, I'd suggest you open issue under https://github.com/akka/akka-management. Also I am not sure if you do want the "management" port to take advantage of Istio's routing feature. |
This creates labels for com.lightbend.rp.management-endpoint and com.lightbend.rp.remoting-endpoint, and changes the default names to `"management"` and `"remoting"`, following the convention set in Akka Management documentation. Ref lightbend/reactive-cli#177
Create an instance of Config to pick up the port number for Play, Akka remoting, and Akka Management.
eed3si9n
force-pushed
the
wip/endpoint
branch
from
2e5eba5 to
bbeab36
Compare
eed3si9n
force-pushed
the
wip/endpoint
branch
from
2197376 to
fe9115d
Compare
eed3si9n
changed the title
eed3si9n
changed the title
eed3si9n
added a commit
to lightbend/reactive-cli
that referenced
this pull request
Jan 29, 2019
Ref lightbend/reactive-lib#117 Ref lightbend/sbt-reactive-app#164 Since sbt-reactive-app captures the endpoint ports (such as port 9000), and because reactive-lib no longer attempts to override the ports for Play and Akka, the RP_ENDPOINT* environment variables are no longer necessary.
eed3si9n
added a commit
that referenced
this pull request
Feb 14, 2019
#164 implemented endpoint port probing using Lightbend Config. It turns out there's a seprate http endpoint creation going on for Lagom, which I missed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This creates labels for com.lightbend.rp.management-endpoint and com.lightbend.rp.remoting-endpoint, and changes the default names to
"management"and"remoting", following the convention set in Akka Management documentation.Ref lightbend/reactive-cli#177
/cc @lightbend/play-lagom