Skip to content
This repository was archived by the owner on May 25, 2023. It is now read-only.

Conversation

cunei
Copy link

@cunei cunei commented Oct 16, 2018

When assembling the rp-application.conf file, the current code
explores the jars in the dependencyClasspath and the unmanaged
resources of the current subproject.
This pull request also includes in the file the unmanaged resources
of the other sbt subprojects that are dependencies of the current
subproject.

See #148

When assembling the `rp-application.conf` file, the current code
explores the jars in the `dependencyClasspath` and the unmanaged
resources of the current subproject.
This pull request also includes in the file the unmanaged resources
of the other sbt subprojects that are dependencies of the current
subproject.

See lightbend#148
Copy link
Contributor

@eed3si9n eed3si9n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eed3si9n eed3si9n merged commit 5b2270a into lightbend:master Oct 16, 2018
@ghost ghost removed the review label Oct 16, 2018
@cunei cunei deleted the wip-unmanaged-deps branch October 16, 2018 15:25
@thomschke
Copy link

thomschke commented Feb 25, 2019

Please see lightbend/config#608 (comment) !!!

sbt-reactive-app uses array concatenations very intensive (for akka.library-extensions etc).

BEFORE your PR all rp-tooling.confs comes before the application.conf:

# akka-cluster-bootstrap
akka {
  library-extensions += "com.lightbend.rp.akkaclusterbootstrap.ClusterBootstrapAutostart"
}
# akka-management
akka {
  library-extensions += "com.lightbend.rp.akkamanagement.AkkaManagementAutostart"
}

...

# application.conf
akka = ${akka}${myapp.default.akka}{
}

So before your PR the runtime config contains all library-extensions because default value substitution runs later.

But now (with reverse order - include application.conf comes first), so the default value substitution comes first:

include "application.conf"

# akka-cluster-bootstrap
akka {
  library-extensions += "com.lightbend.rp.akkaclusterbootstrap.ClusterBootstrapAutostart"
}
# akka-management
akka {
  library-extensions += "com.lightbend.rp.akkamanagement.AkkaManagementAutostart"
}

That's why akka.library-extensions always contains ONE entry (the last defined).

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants