This repository was archived by the owner on May 25, 2023. It is now read-only.
implement YAML generation for discovery-method=akka-dns #195
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #183 For the purpose of Akka Cluster Bootstrap, a specialized label `akka.lightbend.com/service-name` defined. This denotes the Akka Cluster to join when a pod comes up. - The value of the this label will default to either the app name or the app version name depending on the deployment type. - It can be overridden by user using `akkaClusterBootstrapSystemName` setting as described in https://developer.lightbend.com/docs/lightbend-orchestration/current/features/akka-cluster-bootstrap.html. - Deployment pods are labeled with `"akka.lightbend.com/service-name": "friendimpl"` etc - The label selector is overridden as `-Dakka.discovery.kubernetes-api.pod-label-selector=akka.lightbend.com/service-name=%s` (as opposed to using `app=%s`) - The effective name is overridden as `-Dakka.management.cluster.bootstrap.contact-point-discovery.effective-name=friendimpl` etc
This implemets YAML generation for Akka Cluster Boostrap using DNS.
ghost
assigned
|
This will need documentation as well. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is on top of #194
This generates the YAML for Akka Cluster Boostrap under Kubernetes using DNS as described in Akka Management 0.20.0 documentation.
/cc @lightbend/play-team