added option to switch off validation for ConfigBeanFactory use #602

dhakehurst · 2018-12-03T12:19:44Z

Useful in its own right I believe, but this also provides a work around for #440

I have beans that I want instantiated by the config file. But I don't want to set every property of the bean. The bean itself sets default values for some properties. I cannot add the '@optional' annotation to the bean class properties.

switching off the validation allows this.

(I'm using this library for a live project, it is very useful, thanks for all who have contributed towards it.
I need this capability ASAP, and I would rather use an official release over my patched version.)

I have signed the Typesafe Contributor License Agreement online

havocp

Thanks!

I would recommend adding tests for some of the main cases to check that they throw in validation mode and don't throw in non-validation mode. Otherwise this will break the first time someone touches this file again, it's an annoyingly hard file to modify reliably.

havocp · 2018-12-03T14:32:19Z

build.sbt

@@ -4,7 +4,7 @@
 // Release tags should follow: http://semver.org/
 import scalariform.formatter.preferences._

-ThisBuild / git.baseVersion         := "1.3.0"
+ThisBuild / git.baseVersion         := "1.3.4"


This is an unrelated change I guess, ideally not in this PR

the current release is 1.3.3, so I don't know why this was set to 1.3.0.
I changed it to 1.3.4, so that my local publication is at a higher version than the release.
(perhaps it should still read 1.3.3 or 1.3.0?)

havocp · 2018-12-03T14:33:32Z

config/src/main/java/com/typesafe/config/ConfigBeanFactory.java

+     *
+     * @param config source of config information
+     * @param clazz class to be instantiated
+     * @param validate passing false means that the config will not be validated against the bean's implied schema 


I don't love the boolean param ( long story https://blog.ometer.com/2011/01/20/boolean-parameters-are-wrong/ , tldr create(config, clazz, false) doesn't read well).

An alternative would be an Options object like ConfigParseOptions / ConfigResolveOptions, or an enum like ValidationMode { NONE, AUTOMATIC } or something.

That would be an acceptable alternative. though I am fine with booleans.

I am also looking forward to this feature, since i also need it. Therefore, thanks for your contribution on it :)
But i would also think it would be nicer to have more control on the validation. For example to keep the "type" validation for non-null fields, but ignore the optional/null value check, thus allowing null values but validating the type on non-null ones. And similar.
Currently the boolean is disabling/enabling everything

havocp · 2018-12-03T14:48:44Z

config/src/main/java/com/typesafe/config/ConfigBeanFactory.java

+     * Fields are mapped to config by converting the config key to
+     * camel case.  So the key <code>foo-bar</code> becomes JavaBean
+     * setter <code>setFooBar</code>.
+     *


I think this kinda needs to explain what happens if we disable validation and it's invalid. I believe the answer is stuff gets left as whatever it was set to originally in the bean (stuff does not get assigned). But full-on type errors (assign an integer to a list or something) maybe still throw?

havocp · 2018-12-03T14:50:31Z

config/src/test/scala/com/typesafe/config/impl/ParseableReaderTest.scala

+        val e = intercept[ConfigException.Parse] {
+            ConfigFactory.parseReader(configInput)
+        }
+        assertThat(e.getMessage, containsString("Expecting end of input or a comma, got '^'"))
    }


are there changes in this file or just accidental reformatting?

I changed nothing here.

dhakehurst · 2018-12-19T18:24:58Z

Feel free to add to this pull request or superceed it. I have done all i am able to do at this time.

…

On Wed 19. Dec 2018 at 09:32, Ignacio Rodriguez ***@***.***> wrote: ***@***.**** commented on this pull request. ------------------------------ In config/src/main/java/com/typesafe/config/ConfigBeanFactory.java <#602 (comment)>: > + * + * The Java class should follow JavaBean conventions. Field types + * can be any of the types you can normally get from a ***@***.*** + * Config}, including <code>java.time.Duration</code> or ***@***.*** + * ConfigMemorySize}. Fields may also be another JavaBean-style + * class. + * + * Fields are mapped to config by converting the config key to + * camel case. So the key <code>foo-bar</code> becomes JavaBean + * setter <code>setFooBar</code>. + * + * @SInCE 1.3.4 + * + * @param config source of config information + * @param clazz class to be instantiated + * @param validate passing false means that the config will not be validated against the bean's implied schema I am also looking forward to this feature, since i also need it. But i would also think it would be nicer to have more control on the validation. For example to keep the "type" validation for non-null fields, but ignore the optional/null value check, thus allowing null values but validating the type on non-null ones. And similar. Currently the boolean is disabling/enabling everything — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#602 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AFW7Zc_PhE8dwvBsDnmxBbuYHiFAb56Mks5u6fmagaJpZM4Y-eNk> .

… missing props

kringol · 2018-12-20T05:47:24Z

Just added a PR to your own fork with some small changes to match the mechanism of other parts of the library and enable future settings if needed, plus a mini test
dhakehurst#1

Thanks :)

Feel free to add to this pull request or superceed it. I have done all i am able to do at this time.

Introduce a bean factory options parameter

avillev · 2019-02-15T05:21:03Z

Hello there !! @havocp @dhakehurst
Do we have news about this change? I am very interrested.
Does someone plan to have it merged into the project?

dhakehurst · 2019-02-15T16:11:12Z

I do not currently have more time to work on this

…

On Fri, 15 Feb 2019 at 06:21, Arnaud Villevieille ***@***.***> wrote: Hello there !! @havocp <https://github.com/havocp> @dhakehurst <https://github.com/dhakehurst> Do we have new about that change? Does someone plan to have it merged into the project? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#602 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AFW7ZZ1fPRsB-tlEFZD9mkC44F4SgNX_ks5vNkPEgaJpZM4Y-eNk> .

kringol · 2019-02-19T07:15:36Z

I will continue this change on a new PR instead then.
I really want this moving forward and been waiting for it

-> #616

I do not currently have more time to work on this
…
On Fri, 15 Feb 2019 at 06:21, Arnaud Villevieille @.***> wrote: Hello there !! @havocp https://github.com/havocp @dhakehurst https://github.com/dhakehurst Do we have new about that change? Does someone plan to have it merged into the project? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#602 (comment)>, or mute the thread https://github.com/notifications/unsubscribe-auth/AFW7ZZ1fPRsB-tlEFZD9mkC44F4SgNX_ks5vNkPEgaJpZM4Y-eNk .

havocp · 2019-02-21T05:34:58Z

Closing this since it moved to #616

added option to switch off validation for ConfigBeanFactory use

1a07330

havocp reviewed Dec 3, 2018

View reviewed changes

Introduce a bean factory options parameter and a setting for allowing…

19cdbe6

… missing props

Merge pull request #1 from kringol/master

00257e3

Introduce a bean factory options parameter

michalmela mentioned this pull request Jan 4, 2019

Fixed support for keys that look like numbers longer than an int. #568

Merged

kringol mentioned this pull request Feb 19, 2019

Bean validation config to allow missing values or other settings #616

Closed

havocp closed this Feb 21, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

added option to switch off validation for ConfigBeanFactory use #602

added option to switch off validation for ConfigBeanFactory use #602

dhakehurst commented Dec 3, 2018 •

edited

Loading

havocp left a comment

havocp Dec 3, 2018

dhakehurst Dec 4, 2018

havocp Dec 3, 2018

dhakehurst Dec 4, 2018

kringol Dec 19, 2018 •

edited

Loading

havocp Dec 3, 2018

havocp Dec 3, 2018

dhakehurst Dec 4, 2018

dhakehurst commented Dec 19, 2018 via email

kringol commented Dec 20, 2018

avillev commented Feb 15, 2019 •

edited

Loading

dhakehurst commented Feb 15, 2019 via email

kringol commented Feb 19, 2019

havocp commented Feb 21, 2019

added option to switch off validation for ConfigBeanFactory use #602

added option to switch off validation for ConfigBeanFactory use #602

Conversation

dhakehurst commented Dec 3, 2018 • edited Loading

havocp left a comment

Choose a reason for hiding this comment

havocp Dec 3, 2018

Choose a reason for hiding this comment

dhakehurst Dec 4, 2018

Choose a reason for hiding this comment

havocp Dec 3, 2018

Choose a reason for hiding this comment

dhakehurst Dec 4, 2018

Choose a reason for hiding this comment

kringol Dec 19, 2018 • edited Loading

Choose a reason for hiding this comment

havocp Dec 3, 2018

Choose a reason for hiding this comment

havocp Dec 3, 2018

Choose a reason for hiding this comment

dhakehurst Dec 4, 2018

Choose a reason for hiding this comment

dhakehurst commented Dec 19, 2018 via email

kringol commented Dec 20, 2018

avillev commented Feb 15, 2019 • edited Loading

dhakehurst commented Feb 15, 2019 via email

kringol commented Feb 19, 2019

havocp commented Feb 21, 2019

dhakehurst commented Dec 3, 2018 •

edited

Loading

kringol Dec 19, 2018 •

edited

Loading

avillev commented Feb 15, 2019 •

edited

Loading