Skip to content

Use mockito-scala syntax #172

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

ultrasecreth
Copy link
Contributor

mockito-scala make tests easier to read and strict mode to prevent any call to the underlying logger slipping under the radar

… to prevent any call to the underlying logger slipping under the radar
@ultrasecreth
Copy link
Contributor Author

I just signed the CLA

@ultrasecreth
Copy link
Contributor Author

@xuwei-k Just noticed your reaction to the PR, what's the problem with it?

@SethTisue
Copy link
Collaborator

The syntax change seems like a sideways move to me — I tend not to care for these English-y DSLs, I think they tend to make code harder to read, not easier.

So I'm going to close this, in part because this repo seems to be in a semi-unmaintained state anyway so this just feels like churn to me.

However I see the PR description says:

strict mode to prevent any call to the underlying logger slipping under the radar

that sounds like something I would be enthusiastic about merging if it were submitted separately

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants