Upgrade 2.13

[adriaanm]

Upgrade to 2.13.0-RC2 (note: there's a temporary hack to use RC1 artifacts for mockit-scala).

Also clarify (hopefully correctly) use of varargs (not really related to the 2.13 upgrade, but somehow it broke). /cc @szeiger, maybe you have an idea why? (something to do with the switch to immutable seq for varargs?)

[szeiger]

I can't imagine any reason for needing this forceVarargs method. What problem did you run into? It works fine for me with the original List or Array in the tests.

[adriaanm]

--- i/src/test/scala/com/typesafe/scalalogging/LoggerSpec.scala
+++ w/src/test/scala/com/typesafe/scalalogging/LoggerSpec.scala
@@ -92,7 +92,7 @@ class LoggerSpec extends WordSpec with Matchers with MockitoSugar with Varargs {
       val f = fixture(_.isErrorEnabled, isEnabled = true)
       import f._
       logger.error(msg, arg1)
-      verify(underlying).error(msg, arg1)
+      verify(underlying).error(msg, forceVarargs(arg1): _*)
       logger.error(msg, arg1, arg2)
       verify(underlying).error(msg, forceVarargs(arg1, arg2): _*)
       logger.error(msg, arg1, arg2, arg3)

$  ;++2.13.0-RC2;testOnly com.typesafe.scalalogging.LoggerSpec
<snip>

[info] Calling error with a message and parameters
[info] - should call the underlying logger's error method if the error level is enabled *** FAILED ***
[info]   org.mockito.exceptions.verification.WantedButNotInvoked: Wanted but not invoked:
[info] logger.error("msg", "arg1");
[info] -> at com.typesafe.scalalogging.LoggerSpec.$anonfun$new$17(LoggerSpec.scala:95)
[info] 
[info] However, there were exactly 2 interactions with this mock:
[info] logger.isErrorEnabled();
[info] -> at com.typesafe.scalalogging.LoggerSpec.$anonfun$new$17(LoggerSpec.scala:94)
[info] 
[info] logger.error("msg", "arg1");
[info] -> at com.typesafe.scalalogging.LoggerSpec.$anonfun$new$17(LoggerSpec.scala:94)
[info]   at com.typesafe.scalalogging.LoggerSpec.$anonfun$new$17(LoggerSpec.scala:95)
[info]   at scala.runtime.java8.JFunction0$mcV$sp.apply(JFunction0$mcV$sp.scala:18)
[info]   at org.scalatest.OutcomeOf.outcomeOf(OutcomeOf.scala:85)
[info]   at org.scalatest.OutcomeOf.outcomeOf$(OutcomeOf.scala:83)
[info]   at org.scalatest.OutcomeOf$.outcomeOf(OutcomeOf.scala:104)
[info]   at org.scalatest.Transformer.apply(Transformer.scala:22)
[info]   at org.scalatest.Transformer.apply(Transformer.scala:20)
[info]   at org.scalatest.WordSpecLike$$anon$3.apply(WordSpecLike.scala:1075)
[info]   at org.scalatest.TestSuite.withFixture(TestSuite.scala:196)
[info]   at org.scalatest.TestSuite.withFixture$(TestSuite.scala:195)

[adriaanm]

same failure if I use the original List(arg1): _* or scala.Seq

[adriaanm]

It looks like it was trying to assert that the varargs method would be chosen when you call logger.error(msg, arg1), which is not true for 2.12 nor 2.13 (see the example repl session in c093147)

[adriaanm]

This is on:

$ java -version
java version "1.8.0_181"
Java(TM) SE Runtime Environment (build 1.8.0_181-b13)
Java HotSpot(TM) 64-Bit Server VM (build 25.181-b13, mixed mode)

[szeiger]

It looks like it was trying to assert that the varargs method would be chosen when you call logger.error(msg, arg1), which is not true fro 2.12 nor 2.13

This looks correct. The single-arg method is as specific as the varargs method but not vice versa, so it has a higher weight in overload resolution.

[dwijnand]

We should find an agreement on how to land this PR and cut a release. It's blocking:

• KAFKA-7197 expand gradle build: include Scala 2.13 apache/kafka#5454
• which blocks Build with Scala 2.13 embeddedkafka/embedded-kafka#33
• which blocks Cross build for Scala 2.13.0 milestones akka/alpakka-kafka#540
• which blocks Scala 2.13 support lagom/lagom#1240

[adriaanm]

As far as I can see, this PR is good to go.

[octonato]

There is a deprecation warning coming from 2.13.

[warn] /Users/renato/GitHub/lightbend/scala-logging/PR-162/src/main/scala/com/typesafe/scalalogging/LoggerMacro.scala:298:30: method treatEscapes in object StringContext is deprecated (since 2.13.0): use processEscapes
[warn]           .map(StringContext.treatEscapes)

Maybe worth fixing it on this PR. Other than that, we would like to push this forward because it's blocking Kafka, Alpakka and Lagom.

[dwijnand]

@analytically do you have cycles to merge and cut a release with this, please?

[analytically]

scala-logging_2.13.0-RC2-3.9.2 has been released

[dwijnand]

Thanks so much @analytically

[dejan2609]

Version upgrades for Scala-2.13.0-RC3: #165 (I will try to print, sign, scan and send individual CLA asap).

[analytically]

Published scala-logging_2.13.0-RC3-3.9.2

[SethTisue]

scala/make-release-notes@ad61640