Fix pyminifier on Python 2.6 by always checking that sys.version_info is not a tuple #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s completely solves issue liftoff#17
liftoff
added a commit
that referenced
this pull request
Jun 25, 2015
Fix pyminifier on Python 2.6 by always checking that sys.version_info is not a tuple
|
Thanks! I honestly don't care about Python 2.6 very much but I'll gladly accept PRs to fix any issues. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Python 2.6,
sys.version_infois a tuple. Version 2.7 changed it to a named tuple that has the.majorkey. However, checking for.majorbreaks compatibility with 2.6.This PR adds checks to verify that
sys.version_infois indeed not a tuple before checking its.majorattribute. If it's a tuple, it's guaranteed to be <3. This is the same check that got added in this commit.