Remill running on the web via Emscripten

[TrevorSundberg]

See the README.md I added for notes about building and running. I'm very open to make changes or answer questions :)

[alessandrogario]

Can this be moved at the top of the cmake/settings.cmake file? If this new feature does not support other build configurations (such as Debug), we could add a warning message and overwrite the setting.

Example:

if(EMSCRIPTEN)
  ..
  if(NOT "${CMAKE_BUILD_TYPE}" STREQUAL "Release")
    message(WARNING "remill: Using the EMSCRIPTEN toolchain overwrites the build type to Release")
    set(CMAKE_BUILD_TYPE "Release" CACHE STRING "Build type" FORCE)
  endif()
endif()

EDIT: Replaced REMILL_EMSCRIPTEN with the value provided by the toolchain

[TrevorSundberg]

Yeah I love this idea!

[pgoodman]

Has this been resolved?

[alessandrogario]

Is it possible to move these settings in cmake/settings.cmake and use GLOBAL_CXX_FLAGS instead of CMAKE_CXX_FLAGS?

[TrevorSundberg]

Do you prefer this or REMILL_EMSCRIPTEN_CXXFLAGS?

Or let me know if I'm not understanding what is wanted.

[alessandrogario]

The goal is trying to not edit the CMake CXX variables by hand, and append them to the variables used there (which will eventually use property-based target settings such as target_compile_options)

I think it is fine to append them directly with something similar to

if(EMSCRIPTEN)
  list(GLOBAL_CXX_FLAGS APPEND
    flag1
    flag2
  )
endif()

but you can also create a setting such as REMILL_EMSCRIPTEN_CXXFLAGS if you think it may be useful

[alessandrogario]

Can this setting be moved away from the environment variable?

Example, in cmake/settings.cmake

set(REMILL_EMSCRIPTEN_CXXFLAGS "default_value" CACHE STRING "Semicolon separated list of flags")

This will make the flag list show up as a configurable setting (i.e.: make edit_cache).

EDIT: The goal is to avoid using environment variables to configure the project (related: #402 (comment) )

[TrevorSundberg]

This is my first real GitHub PR (I'm used to Azure Devops), when I commit and push the comments that were made just show Outdated and the old code. In Devops when you push the new code is shown next to the comment so the reviewers can verify that it was changed. Is this normal GitHub behavior or is there something I'm supposed to do to tell the PR to use the latest commit? Seeing the Outdated just seems weird.

[pgoodman]

I think we might need some changes to cxx-common to add wasm as a supported target.

[pgoodman]

Hey @TrevorSundberg , just as an FYI, we've all been on a company trip hence the lack of movement. What do you think of us using a cxx-common built clang for the compiler to produce WASM targets? It also seems like LLVM has some kind of support for wasm with 64-bit pointers [1].

[1] https://code.woboq.org/llvm/llvm/include/llvm/ADT/Triple.h.html#llvm::Triple::wasm64

[CLAassistant]

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
_{You have signed the CLA already but the status is still pending? Let us recheck it.}