Improve port upgrading experience #1027
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ekilmer
force-pushed
the
ekilmer/improve-port-upgrading
branch
from
32b336a to
f510683
Compare
Ninja3047
reviewed
Jul 11, 2023
ekilmer
force-pushed
the
ekilmer/improve-port-upgrading
branch
from
f510683 to
40087a5
Compare
Ninja3047
approved these changes
Jul 11, 2023
xlauko
pushed a commit
that referenced
this pull request
Sep 15, 2023
Only upgrade ports that are specified. Also, ask the user if they're sure they want to upgrade. It should prevent accidentally deleting/rebuilding LLVM if it's out of date or if trying to upgrade a port it depends on.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only upgrade ports that are specified. Also ask the user if they're sure they want to upgrade.
Should prevent accidentally deleting/rebuilding LLVM if it's out of date or if trying to upgrade a port it depends on.