Merk hash scheme migration #338
Conversation
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## main #338 +/- ##
==========================================
- Coverage 82.95% 81.00% -1.96%
==========================================
Files 130 131 +1
Lines 15139 15664 +525
==========================================
+ Hits 12558 12688 +130
- Misses 2581 2976 +395
... and 3 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
… from path field of ledger storage
| use merk::tree::Tree; | ||
| use std::collections::BTreeMap; | ||
| use std::path::PathBuf; | ||
| use { |
There was a problem hiding this comment.
Not sure how you got this refactor... We don't use a use { /* all imports */ } pattern anywhere else, so if you could revert this that would be great.
| use merk::rocksdb::{IteratorMode, ReadOptions}; | ||
| use merk::tree::Tree; | ||
| use std::path::PathBuf; | ||
| use { |
There was a problem hiding this comment.
Same as above, I'd like to keep it to one use per import module.
| use tendermint_abci::Application; | ||
| use tendermint_proto::abci::*; | ||
| use tracing::{debug, error}; | ||
| use { |
| use linkme::distributed_slice; | ||
| use many_error::ManyError; | ||
| use many_migration::{InnerMigration, MigrationSet}; | ||
| use { |
| &mut self, | ||
| storage: &mut T, | ||
| block_height: u64, | ||
| path: P, |
There was a problem hiding this comment.
We should discuss this, I'd like to know what other ways we have. It adds a lot of complexity at the call sites. Best case, we don't need to change this method's signature, but in case we have to, this should probably be Option<P> considering how it's used with hardcoded "" sometimes.
| edition = "2021" | ||
| readme = "README.md" |
There was a problem hiding this comment.
Bad merge. Revert this change to the [package] (here and other Cargo.toml).
| Ok((retain_height, hash.into())) | ||
| })() | ||
| .unwrap_or_else(|error| { | ||
| println!("AbciCommitInfo erorr: {error:?}"); |
| @@ -91,4 +99,4 @@ vergen = { version = "8.1.0", features = ["git", "git2"] } | |||
| balance_testing=[] # Enable balance initialization from the CLI | |||
| migration_testing=[] # Enable Dummy migration | |||
| webauthn_testing=[] # Disable WebAuthn token validation from the CLI | |||
| disable_token_sender_check=[] # Disable token endpoint sender validation | |||
| disable_token_sender_check=[] # Disable token endpoint sender validation | |||
| minicbor = { version = "0.19.1", features = ["derive", "std"] } | ||
| once_cell = "1.12" | ||
| proptest = "1" | ||
| serde_json = "1.0.72" | ||
| tempfile = "3.3.0" | ||
| tracing = "0.1.28" | ||
| tracing = "0.1.28" |
| check_consistency --pem=1 --balance=999000 --id="$(identity 1)" 8000 8001 8002 | ||
| check_consistency --pem=2 --balance=1000 --id="$(identity 2)" 8000 8001 8002 | ||
|
|
||
| } |
The ultimate goal of this PR will be to rectify #308