Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use proper form of specs2 dependency #1812

Merged
merged 2 commits into from
Nov 12, 2016
Merged

use proper form of specs2 dependency #1812

merged 2 commits into from
Nov 12, 2016

Conversation

SethTisue
Copy link
Contributor

required for compatibility with Scala 2.12 community build.
and it's the recommended thing anyway

@Shadowfiend
Copy link
Member

Shadowfiend commented Oct 8, 2016

Seems like this guy is missing the dependency for the extra matchers that can do XML and such. If you don't have a chance to look at it I'll see if I can get it over the coming days as I wrestled with this on for lift-formality recently.

@Shadowfiend
Copy link
Member

specs2-matcher-extra is the package. If you can add that and your name/email to contributors.md (unless you're already a committer… I don't know everyone!) then we'll be good to go. Don't think I can push to your fork :/

required for compatibility with Scala 2.12 community build.
and it's the recommended thing anyway
@SethTisue
Copy link
Contributor Author

SethTisue commented Oct 8, 2016

I added myself to contributors.md.

As for adding the dependencies needed to make the webkit subproject compile, I got as far as determining (I think!) that you also need to depend on specs2-mock, too, in order to write Mockito-based tests (see https://etorreborre.github.io/specs2/guide/SPECS2-3.8.5/org.specs2.guide.Installation.html).

But then I started to have to make decisions about how best to fit the additional JARs into the existing structure of the build, and I don't really understand how you're using .copy(configurations = "provided") and why the dependencies aren't added as % "test" as I would usually expect... basically, I think it might be better if you did this last part yourself?

I have now checked the "Allow edits from maintainers" checkbox.

@Shadowfiend
Copy link
Member

Sweet, I'll try and have a look over the next couple of days if no one beats me to it. Thanks!

3.7 splits out specs2 into several sub-packages, and we need 3 of them for most
specs and 2 for webkit's test helpers.
@Shadowfiend
Copy link
Member

Ookay, I think this guy should be good to go. Let's see what travis says 💥

@Shadowfiend
Copy link
Member

Travis says yes, I'm going to go ahead and merge since this isn't a functional change.

@Shadowfiend Shadowfiend merged commit 76f2c93 into lift:master Nov 12, 2016
@Shadowfiend
Copy link
Member

@SethTisue hope this helps, sorry for the delay!

@SethTisue SethTisue deleted the community-build-2.12 branch November 12, 2016 17:47
@SethTisue
Copy link
Contributor Author

thanks Antonio! this allowed scala/community-build#394

@Shadowfiend
Copy link
Member

🎉 Awesome :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants