Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fix to properly handle versions with ~ and locked versions #242

Merged
merged 40 commits into from
Dec 13, 2021

Conversation

jennyEckstein
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Nov 10, 2021

Codecov Report

Merging #242 (7e41f3b) into develop (fa5a8ba) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##           develop      #242   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            1         1           
  Lines           81        86    +5     
  Branches        16        17    +1     
=========================================
+ Hits            81        86    +5     
Impacted Files Coverage Δ
lib/index.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fa5a8ba...7e41f3b. Read the comment docs.

lib/index.js Show resolved Hide resolved
lib/index.test.js Outdated Show resolved Hide resolved
lib/index.test.js Outdated Show resolved Hide resolved
lib/index.test.js Outdated Show resolved Hide resolved
alo3y
alo3y previously approved these changes Nov 17, 2021
lib/utils/get-dependencies.js Outdated Show resolved Hide resolved
lib/utils/get-latest-tag.js Outdated Show resolved Hide resolved
lib/utils/install-dev-packages.js Outdated Show resolved Hide resolved
lib/utils/install-packages.js Outdated Show resolved Hide resolved
@eaviles
Copy link
Member

eaviles commented Dec 6, 2021

I thought the plan was to create a "utils.js" file with only the exec function on it so we could skip it from the coverage. Let's do that instead of creating one file for every single function.

lib/index.js Outdated Show resolved Hide resolved
@jennyEckstein jennyEckstein merged commit 670b910 into develop Dec 13, 2021
@jennyEckstein jennyEckstein deleted the bugfix/respect-locked-versions branch December 13, 2021 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants