Deploy LDA 1.10.0 to various chains #1205
Conversation
|
Warning Rate limit exceeded@0xDEnYO has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 23 minutes and 47 seconds before requesting another review. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. 📒 Files selected for processing (2)
## Walkthrough
This update modifies deployment and configuration JSON files for the "flare," "hyperevm," "viction," and "xdc" networks. It replaces contract addresses for LiFiDEXAggregator and GasZipPeriphery, updates deployment logs, and adds new periphery component keys with empty values to the relevant diamond deployment files. No changes to code or exported entities were made.
## Changes
| Files/Groups | Change Summary |
|------------------------------------------------------------------------------|-------------------------------------------------------------------------------------------------------------------------|
| config/dexs.json | Updated address pairs for "flare," "hyperevm," "viction," and "xdc" networks. |
| deployments/flare.json, deployments/hyperevm.json, deployments/viction.json, deployments/xdc.json | Updated LiFiDEXAggregator and GasZipPeriphery contract addresses for each network. |
| deployments/flare.diamond.json, deployments/hyperevm.diamond.json, deployments/viction.diamond.json, deployments/xdc.diamond.json | Added new empty "LidoWrapper" keys; updated LiFiDEXAggregator and GasZipPeriphery addresses; added a new facet entry in flare.diamond.json. |
| deployments/_deployments_log_file.json | Added new deployment records for version "1.10.0" and updated existing entries for version "1.0.1" with new addresses and timestamps. |
## Possibly related PRs
- lifinance/contracts#1115: Updates deployment addresses for LiFiDEXAggregator and GasZipPeriphery on multiple networks, modifying the same JSON configuration files and keys.
- lifinance/contracts#1166: Adds initial "viction" network configuration and deployment files, which are updated by this PR.
- lifinance/contracts#1180: Adds initial "flare" network configuration and addresses, which are modified by this PR.
## Suggested reviewers
- ezynda3✨ Finishing Touches🧪 Generate Unit Tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 3
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (8)
config/dexs.json(3 hunks)deployments/_deployments_log_file.json(6 hunks)deployments/flare.diamond.json(1 hunks)deployments/flare.json(1 hunks)deployments/viction.diamond.json(1 hunks)deployments/viction.json(1 hunks)deployments/xdc.diamond.json(1 hunks)deployments/xdc.json(1 hunks)
🧰 Additional context used
🧠 Learnings (6)
📓 Common learnings
Learnt from: 0xDEnYO
PR: lifinance/contracts#819
File: deployments/scroll.diamond.json:82-82
Timestamp: 2024-10-09T03:47:21.269Z
Learning: In the `deployments/*.diamond.json` and `deployments/*.json` files, the `LiFiDEXAggregator` contract may intentionally have the same contract address across multiple networks. This is acceptable and should not be flagged as an issue in future code reviews.
Learnt from: 0xDEnYO
PR: lifinance/contracts#1109
File: deployments/worldchain.diamond.json:84-85
Timestamp: 2025-04-21T03:15:12.236Z
Learning: In deployment JSON files that contain "diamond" in their filename (located in the deployments folder), periphery contracts may have empty string values for their addresses. This indicates that the contract is not deployed on that particular chain and should not be flagged as an issue during code reviews.
deployments/xdc.diamond.json (1)
Learnt from: 0xDEnYO
PR: lifinance/contracts#1109
File: deployments/worldchain.diamond.json:84-85
Timestamp: 2025-04-21T03:15:12.236Z
Learning: In deployment JSON files that contain "diamond" in their filename (located in the deployments folder), periphery contracts may have empty string values for their addresses. This indicates that the contract is not deployed on that particular chain and should not be flagged as an issue during code reviews.
deployments/_deployments_log_file.json (2)
undefined
<retrieved_learning>
Learnt from: mirooon
PR: #1170
File: deployments/_deployments_log_file.json:28060-28072
Timestamp: 2025-05-28T17:33:33.959Z
Learning: Deployment log files like deployments/_deployments_log_file.json are historical records that document the actual versions deployed at specific times. They should not be updated to match current contract versions - they must accurately reflect what was deployed when the deployment occurred.
</retrieved_learning>
<retrieved_learning>
Learnt from: mirooon
PR: #1170
File: deployments/_deployments_log_file.json:28706-28717
Timestamp: 2025-05-28T17:33:10.529Z
Learning: Deployment log files (like _deployments_log_file.json) are historical records that should not be updated to match current contract versions. They should accurately reflect the versions that were actually deployed at specific timestamps.
</retrieved_learning>
deployments/xdc.json (1)
Learnt from: 0xDEnYO
PR: lifinance/contracts#819
File: deployments/scroll.diamond.json:82-82
Timestamp: 2024-10-09T03:47:21.269Z
Learning: In the `deployments/*.diamond.json` and `deployments/*.json` files, the `LiFiDEXAggregator` contract may intentionally have the same contract address across multiple networks. This is acceptable and should not be flagged as an issue in future code reviews.
deployments/flare.diamond.json (1)
Learnt from: 0xDEnYO
PR: lifinance/contracts#1109
File: deployments/worldchain.diamond.json:84-85
Timestamp: 2025-04-21T03:15:12.236Z
Learning: In deployment JSON files that contain "diamond" in their filename (located in the deployments folder), periphery contracts may have empty string values for their addresses. This indicates that the contract is not deployed on that particular chain and should not be flagged as an issue during code reviews.
config/dexs.json (2)
Learnt from: ezynda3
PR: lifinance/contracts#861
File: config/dexs.json:748-752
Timestamp: 2024-11-21T08:39:29.530Z
Learning: In the 'worldchain' network, the addresses `0x50D5a8aCFAe13Dceb217E9a071F6c6Bd5bDB4155`, `0x8f023b4193a6b18C227B4a755f8e28B3D30Ef9a1`, and `0x603a538477d44064eA5A5d8C345b4Ff6fca1142a` are used as DEXs and should be included in `config/dexs.json`.
Learnt from: 0xDEnYO
PR: lifinance/contracts#846
File: config/dexs.json:296-300
Timestamp: 2024-11-04T02:25:07.478Z
Learning: In `config/dexs.json`, it's expected that some addresses appear multiple times across different networks.
🪛 Gitleaks (8.26.0)
deployments/viction.diamond.json
60-60: Detected a Generic API Key, potentially exposing access to various services and sensitive operations.
(generic-api-key)
deployments/xdc.diamond.json
64-64: Detected a Generic API Key, potentially exposing access to various services and sensitive operations.
(generic-api-key)
deployments/xdc.json
21-21: Detected a Generic API Key, potentially exposing access to various services and sensitive operations.
(generic-api-key)
⏰ Context from checks skipped due to timeout of 90000ms (2)
- GitHub Check: run-unit-tests
- GitHub Check: Analyze (javascript-typescript)
🔇 Additional comments (13)
deployments/viction.diamond.json (1)
60-63: Acceptable empty periphery entries for viction.diamond.json
Per retrieved conventions, new periphery keys (LidoWrapper,GasZipPeriphery.flattened,LiFiDEXAggregator.flattened) are intentionally left as empty strings when not deployed on this chain.🧰 Tools
🪛 Gitleaks (8.26.0)
60-60: Detected a Generic API Key, potentially exposing access to various services and sensitive operations.
(generic-api-key)
deployments/flare.diamond.json (1)
64-67: Acceptable empty periphery entries for flare.diamond.json
The additions ofGasZipPeriphery.flattened,LidoWrapper, andLiFiDEXAggregator.flattenedwith empty values follow the established diamond deployment pattern for chains where these components aren’t deployed.deployments/viction.json (1)
17-17: Update periphery contract addresses for viction.json
TheLiFiDEXAggregatorandGasZipPeripheryaddresses have been updated to the latest deployed values and align with the entries inconfig/dexs.json.Also applies to: 20-20
deployments/xdc.json (1)
18-18: Update periphery contract addresses for xdc.json
TheLiFiDEXAggregatorandGasZipPeripheryentries have been updated to the new deployment addresses and match the configuration inconfig/dexs.json.Also applies to: 22-22
deployments/xdc.diamond.json (1)
64-67: Acceptable empty periphery entries for xdc.diamond.json
The new periphery keys (GasZipPeriphery.flattened,LidoWrapper,LiFiDEXAggregator.flattened) are correctly initialized as empty for chains without those deployments.🧰 Tools
🪛 Gitleaks (8.26.0)
64-64: Detected a Generic API Key, potentially exposing access to various services and sensitive operations.
(generic-api-key)
deployments/flare.json (2)
18-18: Approve updated LiFiDEXAggregator address.
The new address aligns with the corresponding entry inconfig/dexs.jsonand reflects the intended v1.10.0 deployment.
22-22: Approve updated GasZipPeriphery address.
The new address matches the update inconfig/dexs.jsonand is consistent with the periphery deployment.config/dexs.json (3)
449-450: Approve Flare DEX config updates.
The LiFiDEXAggregator and GasZipPeriphery addresses now matchdeployments/flare.json, ensuring consistency for v1.10.0.
989-990: Approve Viction DEX config updates.
The updated addresses for LiFiDEXAggregator and GasZipPeriphery align withdeployments/viction.json.
1012-1013: Approve XDC DEX config updates.
The LiFiDEXAggregator and GasZipPeriphery addresses correspond to the changes indeployments/xdc.json, maintaining cross-file consistency.deployments/_deployments_log_file.json (3)
29437-29446: Append new "1.10.0" deployment record
This block correctly documents the 1.10.0 deployment. Ensure that theADDRESS,TIMESTAMP,CONSTRUCTOR_ARGS, andVERIFIEDflag match the actual on-chain deployment artifacts.
29497-29506: Append new "1.10.0" deployment record
Valid addition of the 1.10.0 entry. Confirm that the constructor arguments and theVERIFIED: "false"status reflect the intended state for this network.
29535-29544: Append new "1.10.0" deployment record
This entry adds the 1.10.0 log for the staging environment. Verify the timestamp and deployment parameters against your deployment logs to ensure accuracy.
…-1-10-0-to-various
Which Jira task belongs to this PR?
Why did I implement it this way?
Checklist before requesting a review
Checklist for reviewer (DO NOT DEPLOY and contracts BEFORE CHECKING THIS!!!)