This repository has been archived by the owner on Oct 17, 2020. It is now read-only.
fix: #613 don't add empty lines to MANIFEST.MF #614
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Simply avoid empty lines when a header is not configured for the JAR manifest.
wincent
reviewed
Jul 10, 2020
packages/liferay-npm-bundler/src/jar/__tests__/manifest.test.js
Outdated
Show resolved
Hide resolved
wincent
reviewed
Jul 10, 2020
In order to avoid developer's OCD discomfort.
Also change assertions due to header reordering.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Manually tested, but I have also added unit tests (and found an error!)