LRQA-78830 | Update Poshi Standalone support for liferay-frontend-projects repo #1053
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IINM, these tests were done for JS Toolkit v2, which is at https://github.com/liferay/liferay-frontend-projects/tree/master/maintenance/projects/js-toolkit, but some parts of that project are being slowly deprecated in favor of @liferay/cli, which is at https://github.com/liferay/liferay-frontend-projects/tree/master/projects/js-toolkit, so we may want to create the tests there, instead of updating the old ones... CC: @john-co |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updating Poshi standalone to work for liferay-frontend-projects.
Need to check with versions of portal-master with poshiRunnerResources in build.gradle files to see if it works with current tests