Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create lifecycle tests for clay-charts #760

Merged
merged 1 commit into from
Mar 27, 2018
Merged

Create lifecycle tests for clay-charts #760

merged 1 commit into from
Mar 27, 2018

Conversation

julien
Copy link
Contributor

@julien julien commented Mar 27, 2018

Fixes #759

@julien julien mentioned this pull request Mar 27, 2018
Merged
@julien julien requested a review from jbalsas March 27, 2018 20:13
@coveralls
Copy link

Pull Request Test Coverage Report for Build 561

  • 25 of 27 (92.59%) changed or added relevant lines in 2 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.05%) to 81.942%
Changes Missing Coverage Covered Lines Changed/Added Lines %
packages/clay-charts/src/ChartBase.js 15 17 88.24%
Files with Coverage Reduction New Missed Lines %
packages/clay-charts/src/ChartBase.js 1 76.47%
Totals Coverage Status
Change from base Build 560: 0.05%
Covered Lines: 4605
Relevant Lines: 4869
💛 - Coveralls

@jbalsas
Copy link
Contributor

jbalsas commented Mar 27, 2018

Awesome, thanks!

@jbalsas jbalsas merged commit c99848e into liferay:develop Mar 27, 2018
@julien julien deleted the issue-759 branch March 28, 2018 06:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jbalsas jbalsas Awaiting requested review from jbalsas

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@julien @coveralls @jbalsas