Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Advanced Search to ClayManagementToolbar | Fixes #609 #622

Merged
merged 7 commits into from
Feb 23, 2018
Merged

Add Advanced Search to ClayManagementToolbar | Fixes #609 #622

merged 7 commits into from
Feb 23, 2018

Conversation

carloslancha
Copy link
Contributor

No description provided.

@coveralls
Copy link

coveralls commented Feb 22, 2018 •
edited
Loading

Pull Request Test Coverage Report for Build 338

  • 0 of 0 (NaN%) changed or added relevant lines in 0 files are covered.
  • 31 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.3%) to 81.822%
Files with Coverage Reduction New Missed Lines %
packages/clay-dropdown/src/ClayDropdownBase.soy.js 6 79.93%
packages/generator-metal-clay/app/index.js 25 15.0%
Totals Coverage Status
Change from base Build 337: -0.3%
Covered Lines: 4477
Relevant Lines: 4741
💛 - Coveralls

@carloslancha carloslancha changed the title Regen snapshots | Fixes #609 Add Advanced Search to ClayManagementToolbar | Fixes #609 Feb 22, 2018
@matuzalemsteles
Copy link
Member

Just started reviewing :)

:octocat: Sent from GH.

matuzalemsteles
matuzalemsteles reviewed Feb 22, 2018
View reviewed changes
packages/clay-management-toolbar/src/ClayManagementToolbar.soy
{call ClayDropdown.render}
{param contentRenderer: $contentRenderer /}
{param icon: 'angle-down' /}
{param items: [] /}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @carloslancha, is this expected?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, since I don't want items to be an optional parameter we need to do this.

@jbalsas jbalsas merged commit faf2672 into liferay:develop Feb 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matuzalemsteles matuzalemsteles matuzalemsteles left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@carloslancha @coveralls @matuzalemsteles @jbalsas