Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates CHANGELOG for v2.0.0-rc.0 #541

Merged
merged 40 commits into from
Feb 9, 2018
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
40 commits
Select commit Hold shift + click to select a range
43e7079
Update: (Fixes #504) Side Navigation JS breakpoint region should use …
pat270 Feb 2, 2018
0eba3e5
Merge pull request #506 from pat270/clay-504
jbalsas Feb 5, 2018
d87612d
Use tiles only when they are passed. | Fixes #495
matuzalemsteles Feb 5, 2018
9a3a75a
Improve the API to use array with tile names | Fixes #495
matuzalemsteles Feb 5, 2018
9c673da
Get tiles by DOM and use only when true | Fixes #495
matuzalemsteles Feb 6, 2018
d2d29f4
Regen snapshots | Fixes #495
matuzalemsteles Feb 6, 2018
c199874
Improves the use of tiles to be called only when created | Fixes #495
matuzalemsteles Feb 6, 2018
d5b4390
SF | Fixes #495
matuzalemsteles Feb 6, 2018
dbd392a
Update prettier-eslint-cli to 4.7.0
matuzalemsteles Feb 6, 2018
e9bf8ac
Regen yarn.lock
matuzalemsteles Feb 6, 2018
848afd0
SF
matuzalemsteles Feb 6, 2018
72351bf
Merge pull request #514 from matuzalemsteles/UpdatePrettier
jbalsas Feb 6, 2018
838ba40
Fix accessibility issue | Fixes #518
matuzalemsteles Feb 6, 2018
9bfc52c
Add Chart examples to claycss.com
Feb 7, 2018
0a77c12
Merge pull request #513 from matuzalemsteles/issue-495-2
julien Feb 7, 2018
bcfe6b2
Merge pull request #521 from julien/clay-docs
jbalsas Feb 7, 2018
51786c6
Update the Table markup at claycss.com
matuzalemsteles Feb 7, 2018
ffaaf89
Update: (Fixes #516) Forms `.form-control` in Firefox should shrink t…
pat270 Feb 8, 2018
cee533e
Implements Geomap Chart (Fixes #509)
Feb 8, 2018
5e9552a
Makes sure we run soy before generating the site (Fixes #509)
jbalsas Feb 8, 2018
ccef797
Merge pull request #529 from liferay/pr-525
jbalsas Feb 8, 2018
28aafa9
Merge pull request #524 from pat270/clay-516
jbalsas Feb 8, 2018
c2e6aaa
Update metal-tools-soy to v6.0.0 | Fixes #530
Jan 27, 2018
26d5af7
Inputs need to be self closing | Fixes #530
Jan 27, 2018
e2af842
Update ClayDropdown markup to use always lists | Fixes #527 and #530
Feb 8, 2018
e7c2035
Fix ClayCardGrid markup issues | Fixes #530
Feb 8, 2018
34a85af
Regen snapshots | Fixes #530
Feb 8, 2018
6682e21
Merge pull request #519 from matuzalemsteles/FixAccessibilityClayMana…
jbalsas Feb 8, 2018
4c83874
Update: (Fixes #512) `navbar-size` mixin should set height on `.navba…
pat270 Feb 8, 2018
ea50dd9
Merge pull request #533 from carloslancha/UpdateMetaltoolssoy
jbalsas Feb 8, 2018
5bf5c8e
Site: (#512) Management Bar added examples of Management Bars with on…
pat270 Feb 8, 2018
f96ff7c
Update: (#537) Form Validation added `.form-feedback-group` container…
pat270 Feb 8, 2018
ebdd8a4
Update markups on form elements at claycss.com
matuzalemsteles Feb 8, 2018
9200c25
Update: Form Group Autofit `label` shouldn't expand full width of its…
pat270 Feb 8, 2018
9881795
Breaking: (Fixes #537) Input Group remove support for mixing various …
pat270 Feb 9, 2018
d4a74c7
Site: (#537) Forms wrap all feedback text in `.form-feedback-group`, …
pat270 Feb 9, 2018
d2e7e84
Merge pull request #539 from matuzalemsteles/UpdateMarkupTableClaycss
jbalsas Feb 9, 2018
b61fdfe
Merge pull request #538 from matuzalemsteles/UpdateMarkupFormsElements
jbalsas Feb 9, 2018
8d81d10
Merge pull request #535 from pat270/clay-512
jbalsas Feb 9, 2018
202dfd8
Merge pull request #540 from pat270/clay-537
jbalsas Feb 9, 2018
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Get tiles by DOM and use only when true | Fixes #495
  • Loading branch information
matuzalemsteles committed Feb 6, 2018
commit 9c673da72d72974cb12f967c7b7f0d0b02558df2
2 changes: 1 addition & 1 deletion packages/clay-charts/demos/index.html
Original file line number Diff line number Diff line change
Expand Up @@ -392,7 +392,7 @@ <h2>Bubble</h2>
var pieChart = new metal.PieChart({
columns: dummyPercentData.columns_1,
color: {
tiles: ['circles', 'horizontal-large', 'vertical-small']
tiles: true
},
legend: {
contents: {
Expand Down
36 changes: 8 additions & 28 deletions packages/clay-charts/src/ChartBase.js
Original file line number Diff line number Diff line change
@@ -1,7 +1,5 @@
import {bb, d3} from 'billboard.js';
import {Config} from 'metal-state';
import SVG from './svg/svg';
import TILES_PATTERNS from './svg/types';
import types from './utils/types';

const PROP_NAME_MAP = {
Expand Down Expand Up @@ -243,7 +241,7 @@ const ChartBase = {
let {colors, color, columns} = this.getStateObj_();

if (color && color.tiles) {
const tiles = typeof color.tiles === 'function' ? color.tiles : this.getTiles_(color.tiles);
const tiles = typeof color.tiles === 'function' ? color.tiles : this.getTiles_();

color.pattern = color.pattern || DEFAULT_COLORS;
color.tiles = () => tiles;
Expand Down Expand Up @@ -413,20 +411,14 @@ const ChartBase = {
},

/**
* Creates the tiles defaults and returns it according to what
* is selected.
* Get all tiles of the DOM.
* @return {?Elements}
* @protected
*/
getTiles_: function(tiles) {
const svg = new SVG();
const tilesPatterns = svg.create(TILES_PATTERNS);

return tiles.map(elem => {
return tilesPatterns.find(val => {
return val.id == elem;
});
});
getTiles_: function() {
return DEFAULT_TILES.filter(val => {
return document.querySelector(`#${val}`);
}).map(val => document.querySelector(`#${val}`));
},

/**
Expand Down Expand Up @@ -697,20 +689,8 @@ ChartBase.STATE = {
max: Config.number(),
}),
tiles: Config.oneOfType([
Config.arrayOf(
Config.oneOf([
'circles',
'diagonal-left-large',
'diagonal-left-small',
'diagonal-right-large',
'diagonal-right-small',
'horizontal-large',
'horizontal-small',
'vertical-large',
'vertical-small'
])
),
Config.func()
Config.bool().value(false),
Config.func(),
]),
}),

Expand Down