fix(@clayui/css): Mixins clay-select-variant update to use `clay-cs…

[pat270]

…s` pattern, also deprecated keys should win over new keys

fix(@clayui/css): Update Sass maps that use clay-select-variant to use new keys: $date-picker-nav-select and $input-select

fixes #4046

[matuzalemsteles]

Hey @pat270 I'm taking a look at this to understand more about how everything is working around Clay CSS, so I'm going to ask more questions from now on, probably always doubts.

[matuzalemsteles]

Just a question about the unrelated this change:

• Double declaration in sequence: the last declaration rewrite the last declaration, right? why double declaration?
• Once you removed the last declaration, what's the expected side effect? if it exist, of course.

[pat270]

@matuzalemsteles Not a problem, map-merge takes whatever was declared in the first map and combines the two. If there are two keys with the same name in both maps, whatever is declared in the second map wins between the two. This is a way (hack?) to provide default values with Sass maps.

An example that may help explain better:

// This one replaces `$map: () !default;` below it
$map: (
  background-color: #eee,
  color: red,
) !default;

$map: () !default;
$map: map-merge((
  color: black,
  font-size: 16px,
), $map);

// $map will be:
$map: (
  background-color: #eee,
  color: red,
  font-size: 16px,
);

If we don't use map-merge while providing default values:

$map: (
  background-color: #eee,
  color: red,
) !default;

$map: (
  color: black,
  font-size: 16px,
) !default;

// $map will be:
$map: (
  background-color: #eee,
  color: red,
);

The reason we don't need it here is because we aren't providing any default values for $date-picker-nav-select.

[matuzalemsteles]

Hmm makes sense, thanks for the clarification.

[matuzalemsteles]

LGTM

[marcoscv-work]

LGTM and merge!

[marcoscv-work]

I'm not sure why it was for 13 days here...