fix: apply layout components throughout #3256
Conversation
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 3c1308c:
|
Pull Request Test Coverage Report for Build 111837807
💛 - Coveralls |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit e8a6d0e:
|
| @@ -7,6 +7,7 @@ import {ClayDropDownWithItems} from '@clayui/drop-down'; | |||
| import {ClayCheckbox} from '@clayui/form'; | |||
| import ClayIcon from '@clayui/icon'; | |||
| import ClayLabel from '@clayui/label'; | |||
| import * as ClayLayout from '@clayui/layout'; | |||
There was a problem hiding this comment.
This one is taken as an example, I've seen similar cases throughout the commit, but we seem to be importing all and then just using one subcomponent. In this case <ClayLayout.ContentCol on lines 140 & 163
There was a problem hiding this comment.
Just updated to have a default export so that we don't have to do this
| @@ -33,7 +34,9 @@ const ClayManagementToolbar: React.FunctionComponent<IProps> & { | |||
| } | |||
| )} | |||
| > | |||
| <div className="container-fluid container-fluid-max-xl">{children}</div> | |||
| <ClayLayout.ContainerFluid size="xl"> | |||
There was a problem hiding this comment.
Is size really necessary as it's the default already?
There was a problem hiding this comment.
it is not necessary... i just forgot there was a default
| @@ -18,7 +19,7 @@ export default () => { | |||
| const [selectedItems, setSelectedItems] = React.useState<any>([]); | |||
|
|
|||
| return ( | |||
| <div className="container-fluid"> | |||
| <ClayLayout.ContainerFluid> | |||
There was a problem hiding this comment.
Interestingly, this is would actually be xl because of the defaults
| @@ -537,7 +538,7 @@ storiesOf('Demos|Recharts', module) | |||
| </div> | |||
| </div> | |||
|
|
|||
| <div className="container-fluid container-view"> | |||
| <ClayLayout.ContainerFluid view> | |||
There was a problem hiding this comment.
Same, this would actually now be xl because of defaults which might not be so bad after all 😉
|
Going to merge for release |
fixes #3255