-
Notifications
You must be signed in to change notification settings - Fork 496
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(clayui.com): Update content of some components #3226
Conversation
Pull Request Test Coverage Report for Build 110175154
💛 - Coveralls |
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit c4ad126:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See my comment at #3224 (review) regarding h1
tags in our docs.
I also noticed there are quite a few redundancies from the "description" frontmatter in most of these files. I'm not sure if we accidentally removed "description" from being used, but in the past each page was generated with the first block of content being the description from the frontmatter.
Additionally, I noticed you were going through all the css docs as well. I think for now, its best that we not worry about those at the same time as the react docs. Lets iterate first through react and then if needed, we can go through the css docs w/ @pat270. So for this PR and additional PRs, lets not worry about the css docs right now.
I've pushed a commit containing the suggestions, also some notes:
Static files keep getting modifiedIt's been happening for a while now, like a month or even 2, but I keep getting files in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @kresimir-coko, your comment gave me an idea I think we can start with first before actually updating the docs. See my comment below about establishing a grid of questions that we can use to layout our docs.
Hey @bryceosterhaus I've made some more changes to this as taken from the discussion. Not much to it, I've removed some content that I've added when I thought we needed more of it. Also, I've done the changes to Hmm, for some reason CI seems to be breaking, but locally everything looks fine. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kresimir-coko can you check out the failing build? Other than that, it looks good to me
@kresimir-coko for
|
… Breadcrumb, Dual List Box, Loading Indicator, Localized Input & Multi Step Nav
LGTM! |
Addresses some components listed in #3210
@bryceosterhaus I decided to send this halfway through to make it easier to review and iterate over. I'll be working on the other half of the components listed in the issue next.
Here's what I've done:
badges
tobadge
text-input-localizable
tolocalized-input
#
in Markdown)Components included
Something I noticed
Localized Input is missing prop to render textarea, this example was included in the Markup/CSS page but we had no support for that. So I removed the example with the idea of eventually adding it back when we add a prop to the component.