Fixes #990 - Bring linting up to date #994
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🤦 I didn't realize these weren't being picked up in the initial configuration of Prettier and ESLint.
Previous commit updated our package.json scripts; this one shows what the actual results are.
Drops us from: ✖ 801 problems (801 errors, 0 warnings) To: ✖ 529 problems (529 errors, 0 warnings)
Like `CKEDITOR`, this gets assigned as a globally-accessible property on
the `window` object.
Before:
✖ 529 problems (529 errors, 0 warnings)
After:
✖ 436 problems (436 errors, 0 warnings)
We have too many of these to fix right now. If even warnings turn out to
be too noisy we can turn this off entirely by switching 'warn' to 'off'.
(Note that I also changed an existing 2 → "error", because
"off"/"warn"/"error" is more readable than 0/1/2.)
Before:
✖ 436 problems (436 errors, 0 warnings)
After:
✖ 436 problems (324 errors, 112 warnings)
We'll have to chew through these slowly over time.
Before:
✖ 436 problems (324 errors, 112 warnings)
After:
✖ 436 problems (272 errors, 164 warnings)
If the warnings get too noisy you can always suppress them with:
npm run lint -- --quiet
julien
approved these changes
Jan 24, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a duplicate of #991 (which I don't want to touch right now because Travis is wobbly and is actually green on that one) but with two more commits added on top because I just realized that we weren't running lints or formatting on JSX files.